Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2667383008: Move one CircularBuffer to webrtc::test namespace. (Closed)

Created:
3 years, 10 months ago by brandtr
Modified:
3 years, 10 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move one CircularBuffer to webrtc::test namespace. There are currently two webrtc::CircularBuffers defined: - modules/audio_coding/test/utility.{h,cc} - modules/audio_processing/echo_detector/circular_buffer.{h,cc} This CL moves the former definition to the webrtc::test namespace, to avoid link errors in a future build target. BUG=None Review-Url: https://codereview.webrtc.org/2667383008 Cr-Commit-Position: refs/heads/master@{#16553} Committed: https://chromium.googlesource.com/external/webrtc/+/6607d84b443a26dc1415c767229d73d8d56bdaeb

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M webrtc/modules/audio_coding/test/APITest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/utility.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/test/utility.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
brandtr
Please have a look :)
3 years, 10 months ago (2017-02-03 12:05:13 UTC) #2
brandtr
ping :)
3 years, 10 months ago (2017-02-08 12:40:51 UTC) #3
brandtr
Rebase.
3 years, 10 months ago (2017-02-09 15:02:55 UTC) #4
brandtr
Rebase.
3 years, 10 months ago (2017-02-10 09:27:12 UTC) #5
brandtr
+hlundin, would you mind taking a look? :)
3 years, 10 months ago (2017-02-10 13:10:41 UTC) #8
hlundin-webrtc
lgtm
3 years, 10 months ago (2017-02-10 14:04:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2667383008/40001
3 years, 10 months ago (2017-02-11 08:21:18 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 08:24:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/6607d84b443a26dc1415c7672...

Powered by Google App Engine
This is Rietveld 408576698