Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2666873002: Adding Java wrapper for DtmfSender. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding Java wrapper for DtmfSender. BUG=webrtc:4180 Review-Url: https://codereview.webrtc.org/2666873002 Cr-Commit-Position: refs/heads/master@{#16410} Committed: https://chromium.googlesource.com/external/webrtc/+/24af66397e3e1919b801c8d56926263f90808ea1

Patch Set 1 #

Total comments: 4

Patch Set 2 : javadoc comments + making variable final #

Patch Set 3 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -6 lines) Patch
M webrtc/sdk/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/sdk/android/api/org/webrtc/DtmfSender.java View 1 1 chunk +84 lines, -0 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/RtpSender.java View 1 3 chunks +17 lines, -1 line 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java View 2 chunks +13 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/peerconnection_jni.cc View 3 chunks +52 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Taylor Brandstetter
3 years, 10 months ago (2017-01-31 08:32:35 UTC) #2
magjed_webrtc
lgtm % nits https://codereview.webrtc.org/2666873002/diff/1/webrtc/sdk/android/api/org/webrtc/DtmfSender.java File webrtc/sdk/android/api/org/webrtc/DtmfSender.java (right): https://codereview.webrtc.org/2666873002/diff/1/webrtc/sdk/android/api/org/webrtc/DtmfSender.java#newcode21 webrtc/sdk/android/api/org/webrtc/DtmfSender.java:21: // Returns true if this DtmfSender ...
3 years, 10 months ago (2017-02-01 13:08:51 UTC) #3
Taylor Brandstetter
https://codereview.webrtc.org/2666873002/diff/1/webrtc/sdk/android/api/org/webrtc/DtmfSender.java File webrtc/sdk/android/api/org/webrtc/DtmfSender.java (right): https://codereview.webrtc.org/2666873002/diff/1/webrtc/sdk/android/api/org/webrtc/DtmfSender.java#newcode21 webrtc/sdk/android/api/org/webrtc/DtmfSender.java:21: // Returns true if this DtmfSender is capable of ...
3 years, 10 months ago (2017-02-01 17:31:28 UTC) #4
pthatcher1
lgtm
3 years, 10 months ago (2017-02-02 01:34:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2666873002/40001
3 years, 10 months ago (2017-02-02 05:10:33 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 05:53:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/24af66397e3e1919b801c8d56...

Powered by Google App Engine
This is Rietveld 408576698