Move frame_generator_capture.{cc, h} and video_capturer.h to video_test_common.

Move frame_generator_capture.{cc, h} and video_capturer.h to video_test_common.

Remove video_capture as a dependency of test_common and add it as a dependency of modules_unittests, as it was before the refactor in https://codereview.webrtc.org/2629923002

BUG=webrtc:7037
NOTRY=True

Review-Url: https://codereview.webrtc.org/2666113003
Cr-Commit-Position: refs/heads/master@{#16439}
Committed: https://chromium.googlesource.com/external/webrtc/+/656610fbe7a1339f5576cafb8564b5d7609c6be9

[ehmaldonado_webrtc, 2017-02-01 13:29:17]

Patchset #1 (id:1) has been deleted

[ehmaldonado_webrtc, 2017-02-01 13:30:14]

Description was changed from

==========
Move things around

BUG=webrtc:7037
==========

to

==========
Move frame_generator_capture.{cc, h} to video_test_common.

BUG=webrtc:7037
==========

[ehmaldonado_webrtc, 2017-02-01 13:32:21]

Description was changed from

==========
Move frame_generator_capture.{cc, h} to video_test_common.

BUG=webrtc:7037
==========

to

==========
Move frame_generator_capture.{cc, h} and video_capturer.h to video_test_common.

Remove video_capture as a dependency of test_common and add it as a dependency
of modules_unittests, as it was before the refactor in
https://codereview.webrtc.org/2629923002

BUG=webrtc:7037
==========

[ehmaldonado_webrtc, 2017-02-01 13:39:51]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2017-02-01 13:56:10]

ehmaldonado@webrtc.org changed reviewers:
+ mflodman@webrtc.org, perkj@webrtc.org

[ehmaldonado_webrtc, 2017-02-01 13:56:11]

ehmaldonado@webrtc.org changed reviewers:
+ mflodman@webrtc.org, perkj@webrtc.org

[kjellander_webrtc, 2017-02-01 13:57:07]

lgtm but I'd like to get input from a video capture owner as well.

[perkj_webrtc, 2017-02-03 06:51:32]

lgtm

https://codereview.webrtc.org/2666113003/diff/20001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2666113003/diff/20001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:335: "../modules/video_capture:video_capture_module",
Can you remove video_capture_module dependency as well?

[ehmaldonado_webrtc, 2017-02-03 08:02:23]

Patchset #2 (id:40001) has been deleted

[ehmaldonado_webrtc, 2017-02-03 08:13:07]

https://codereview.webrtc.org/2666113003/diff/20001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2666113003/diff/20001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:335: "../modules/video_capture:video_capture_module",
On 2017/02/03 06:51:32, perkj_webrtc wrote:
> Can you remove video_capture_module dependency as well?

vcm_capturer.{cc, h} needs it, should I move it to video_test_common too, or to
another target?

[perkj_webrtc, 2017-02-03 08:19:19]

On 2017/02/03 08:13:07, ehmaldonado_webrtc wrote:
> https://codereview.webrtc.org/2666113003/diff/20001/webrtc/test/BUILD.gn
> File webrtc/test/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2666113003/diff/20001/webrtc/test/BUILD.gn#newc...
> webrtc/test/BUILD.gn:335: "../modules/video_capture:video_capture_module",
> On 2017/02/03 06:51:32, perkj_webrtc wrote:
> > Can you remove video_capture_module dependency as well?
> 
> vcm_capturer.{cc, h} needs it, should I move it to video_test_common too, or
to
> another target?

I think it make sence to move to video_test_common.

[ehmaldonado_webrtc, 2017-02-03 11:43:48]

Still LGTM?

[kjellander_webrtc, 2017-02-03 13:03:06]

lgtm

[ehmaldonado_webrtc, 2017-02-03 13:46:37]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-02-03 13:46:37]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2666113003/#ps60001 (title:
"Also remove video_capture_module dependency.")

[commit-bot: I haz the power, 2017-02-03 13:46:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-03 14:01:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 14:01:33]

Try jobs failed on following builders:
  linux_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)

[ehmaldonado_webrtc, 2017-02-03 15:23:07]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-02-03 15:23:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2666113003/#ps80001 (title:
"Change video_capture by video_capture_module as a dependency of
video_test_common.")

[commit-bot: I haz the power, 2017-02-03 15:23:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-03 15:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 15:39:49]

Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17110)

[ehmaldonado_webrtc, 2017-02-03 16:42:54]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 16:43:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-03 16:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 16:44:56]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17116)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/16944)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/22377)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21120)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/21584)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/18396)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[ehmaldonado_webrtc, 2017-02-03 16:50:30]

Patchset #4 (id:100001) has been deleted

[ehmaldonado_webrtc, 2017-02-03 16:50:53]

Patchset #3 (id:80001) has been deleted

[ehmaldonado_webrtc, 2017-02-03 16:51:00]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 16:51:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-03 16:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 16:53:57]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17117)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/16945)

[ehmaldonado_webrtc, 2017-02-03 17:15:51]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 17:16:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-03 17:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 17:19:53]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)

[ehmaldonado_webrtc, 2017-02-03 17:22:29]

Patchset #3 (id:120001) has been deleted

[ehmaldonado_webrtc, 2017-02-03 17:31:45]

Patchset #3 (id:140001) has been deleted

[ehmaldonado_webrtc, 2017-02-03 17:36:25]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 17:36:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-03 17:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 17:43:00]

Dry run: Try jobs failed on following builders:
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/17347)

[ehmaldonado_webrtc, 2017-02-03 17:47:20]

On 2017/02/03 08:19:19, perkj_webrtc wrote:
> I think it make sence to move to video_test_common.

Done. I needed to split video_test_support.
PTAL

[kjellander_webrtc, 2017-02-03 19:02:38]

On 2017/02/03 17:47:20, ehmaldonado_webrtc wrote:
> On 2017/02/03 08:19:19, perkj_webrtc wrote:
> > I think it make sence to move to video_test_common.
> 
> Done. I needed to split video_test_support.
> PTAL

Nice, more targets means (usually) less redundant code is built and better
parallelization of the build. Still lgtm

[ehmaldonado_webrtc, 2017-02-06 10:18:06]

Description was changed from

==========
Move frame_generator_capture.{cc, h} and video_capturer.h to video_test_common.

Remove video_capture as a dependency of test_common and add it as a dependency
of modules_unittests, as it was before the refactor in
https://codereview.webrtc.org/2629923002

BUG=webrtc:7037
==========

to

==========
Move frame_generator_capture.{cc, h} and video_capturer.h to video_test_common.

Remove video_capture as a dependency of test_common and add it as a dependency
of modules_unittests, as it was before the refactor in
https://codereview.webrtc.org/2629923002

BUG=webrtc:7037
NOTRY=True
==========

[ehmaldonado_webrtc, 2017-02-06 10:18:13]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-02-06 10:18:15]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2666113003/#ps160001 (title:
"Split off video_test_support")

[commit-bot: I haz the power, 2017-02-06 10:18:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-06 10:21:11]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1486376293478310,
"parent_rev": "a7111eb45a600e1144c59414734108322f722762", "commit_rev":
"656610fbe7a1339f5576cafb8564b5d7609c6be9"}

[commit-bot: I haz the power, 2017-02-06 10:21:15]

Description was changed from

==========
Move frame_generator_capture.{cc, h} and video_capturer.h to video_test_common.

Remove video_capture as a dependency of test_common and add it as a dependency
of modules_unittests, as it was before the refactor in
https://codereview.webrtc.org/2629923002

BUG=webrtc:7037
NOTRY=True
==========

to

==========
Move frame_generator_capture.{cc, h} and video_capturer.h to video_test_common.

Remove video_capture as a dependency of test_common and add it as a dependency
of modules_unittests, as it was before the refactor in
https://codereview.webrtc.org/2629923002

BUG=webrtc:7037
NOTRY=True

Review-Url: https://codereview.webrtc.org/2666113003
Cr-Commit-Position: refs/heads/master@{#16439}
Committed:
https://chromium.googlesource.com/external/webrtc/+/656610fbe7a1339f5576cafb8...
==========

[commit-bot: I haz the power, 2017-02-06 10:21:18]

Committed patchset #3 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/656610fbe7a1339f5576cafb8...