Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2664213002:
Don't send audio packets if the network is down. (Closed)
|
Created:
3 years, 10 months ago by stefan-webrtc Modified:
3 years, 10 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDon't send audio packets if the network is down.
BUG=webrtc:7083
Review-Url: https://codereview.webrtc.org/2664213002
Cr-Commit-Position: refs/heads/master@{#16397}
Committed: https://chromium.googlesource.com/external/webrtc/+/099110cf4b5d728a7bacc47810635b82752df448
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
stefan@webrtc.org changed reviewers: + skvlad@webrtc.org
FYI, I haven't done much testing to verify that this is fine.
The CQ bit was checked by stefan@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by skvlad@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by skvlad@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
stefan@webrtc.org changed reviewers: + philipel@webrtc.org
lgtm
The CQ bit was checked by stefan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485950104480320, "parent_rev":
"4637b6afca431be8caf1d22151a2cbb2e86a33d5", "commit_rev":
"099110cf4b5d728a7bacc47810635b82752df448"}
Message was sent while issue was closed.
Description was changed from ========== Don't send audio packets if the network is down. BUG=webrtc:7083 ========== to ========== Don't send audio packets if the network is down. BUG=webrtc:7083 Review-Url: https://codereview.webrtc.org/2664213002 Cr-Commit-Position: refs/heads/master@{#16397} Committed: https://chromium.googlesource.com/external/webrtc/+/099110cf4b5d728a7bacc4781... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/099110cf4b5d728a7bacc4781... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
