Fix and improve FlexFEC configuration for RTP/RTCP.

Fix and improve FlexFEC configuration for RTP/RTCP.

Fix: Order of assignments is now correct, after being incorrect
due to an incorrect merge between
https://codereview.webrtc.org/2617373002/ and
https://codereview.webrtc.org/2589713003.

Improvement: Set parameters in more places, allowing for
correct reconfiguration. Add TODOs to point of minor issues
with current configuration.

TESTED=By locally patching an application using this code.
BUG=webrtc:5654
Review-Url: https://codereview.webrtc.org/2660403004
Cr-Commit-Position: refs/heads/master@{#16431}
Committed: https://chromium.googlesource.com/external/webrtc/+/9d58d945855774c4321ada7d96997dbd1a7a7964

[brandtr, 2017-01-31 16:15:06]

Description was changed from

==========
Fix and improve FlexFEC configuration for RTP/RTCP.

Fix: Order of assignments is now correct, after being incorrect
due to an incorrect merge between
https://codereview.webrtc.org/2617373002/ and
https://codereview.webrtc.org/2589713003.

Improvement: Set parameters in more places, allowing for
correct reconfiguration. Add TODOs to point of minor issues
with current configuration.

BUG=webrtc:5654
==========

to

==========
Fix and improve FlexFEC configuration for RTP/RTCP.

Fix: Order of assignments is now correct, after being incorrect
due to an incorrect merge between
https://codereview.webrtc.org/2617373002/ and
https://codereview.webrtc.org/2589713003.

Improvement: Set parameters in more places, allowing for
correct reconfiguration. Add TODOs to point of minor issues
with current configuration.

TESTED=By locally patching an application using this code.
BUG=webrtc:5654
==========

[brandtr, 2017-02-01 10:11:40]

brandtr@webrtc.org changed reviewers:
+ stefan@webrtc.org

[brandtr, 2017-02-01 10:11:41]

https://codereview.webrtc.org/2660403004/diff/40001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/2660403004/diff/40001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvideoengine2.cc:1239:
flexfec_config->rtp_header_extensions = config->rtp.extensions;
Note how this assignment is affected by the move of line 1238.

This incorrect order was due to the the interaction of the two CLs in the
description.

[brandtr, 2017-02-03 11:37:44]

ping Stefan.

Would be good to have this one in, to simplify some further on device-testing.

[stefan-webrtc, 2017-02-03 11:49:46]

lgtm

[brandtr, 2017-02-03 11:59:42]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2017-02-03 11:59:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-03 12:43:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486123182630910,
"parent_rev": "4cb1b7546bd7657e051ef0b29f6b15960be7c03e", "commit_rev":
"9d58d945855774c4321ada7d96997dbd1a7a7964"}

[commit-bot: I haz the power, 2017-02-03 12:43:44]

Description was changed from

==========
Fix and improve FlexFEC configuration for RTP/RTCP.

Fix: Order of assignments is now correct, after being incorrect
due to an incorrect merge between
https://codereview.webrtc.org/2617373002/ and
https://codereview.webrtc.org/2589713003.

Improvement: Set parameters in more places, allowing for
correct reconfiguration. Add TODOs to point of minor issues
with current configuration.

TESTED=By locally patching an application using this code.
BUG=webrtc:5654
==========

to

==========
Fix and improve FlexFEC configuration for RTP/RTCP.

Fix: Order of assignments is now correct, after being incorrect
due to an incorrect merge between
https://codereview.webrtc.org/2617373002/ and
https://codereview.webrtc.org/2589713003.

Improvement: Set parameters in more places, allowing for
correct reconfiguration. Add TODOs to point of minor issues
with current configuration.

TESTED=By locally patching an application using this code.
BUG=webrtc:5654

Review-Url: https://codereview.webrtc.org/2660403004
Cr-Commit-Position: refs/heads/master@{#16431}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9d58d945855774c4321ada7d9...
==========

[commit-bot: I haz the power, 2017-02-03 12:43:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/9d58d945855774c4321ada7d9...