Replace src/ios copy with DEPS mirror.

Replace src/ios copy with DEPS mirror.

BUG=webrtc:6934
R=ehmaldonado@webrtc.org
TBR=henrika@webrtc.org

Review-Url: https://codereview.webrtc.org/2659493002 .
Cr-Commit-Position: refs/heads/master@{#16300}
Committed: https://chromium.googlesource.com/external/webrtc/+/c3c82362f706216f9e1c31ef0ca27531d32e0526

[kjellander_webrtc, 2017-01-26 13:45:09]

kjellander@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org

[kjellander_webrtc, 2017-01-26 13:45:09]

Trybots seems unable to handle this patch. I'd like to commit anyway since it's
just a move. I've tried patching my local other machine and sync, and that
works.

[kthelgason, 2017-01-26 14:45:34]

kthelgason@webrtc.org changed reviewers:
+ kthelgason@webrtc.org

[kthelgason, 2017-01-26 14:45:35]

https://codereview.webrtc.org/2659493002/diff/40001/DEPS
File DEPS (right):

https://codereview.webrtc.org/2659493002/diff/40001/DEPS#newcode46
DEPS:46: 'src/ios':
Shouldn't this be down in `deps_os`? No need to pull it in all the time right?

[kjellander_webrtc, 2017-01-26 15:11:10]

https://codereview.webrtc.org/2659493002/diff/40001/DEPS
File DEPS (right):

https://codereview.webrtc.org/2659493002/diff/40001/DEPS#newcode46
DEPS:46: 'src/ios':
On 2017/01/26 14:45:34, kthelgason wrote:
> Shouldn't this be down in `deps_os`? No need to pull it in all the time right?

Yes it seems to work. I was afraid it wouldn't due to references in Chromium
that were processed on all platforms (since the dir is always there in Chromium
since it's not a DEPS entry). But deps_os works (proven by the other platform
trybots being green). Thanks for the suggestion.

[ehmaldonado_webrtc, 2017-01-26 15:15:41]

On 2017/01/26 15:11:10, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2659493002/diff/40001/DEPS
> File DEPS (right):
> 
> https://codereview.webrtc.org/2659493002/diff/40001/DEPS#newcode46
> DEPS:46: 'src/ios':
> On 2017/01/26 14:45:34, kthelgason wrote:
> > Shouldn't this be down in `deps_os`? No need to pull it in all the time
right?
> 
> Yes it seems to work. I was afraid it wouldn't due to references in Chromium
> that were processed on all platforms (since the dir is always there in
Chromium
> since it's not a DEPS entry). But deps_os works (proven by the other platform
> trybots being green). Thanks for the suggestion.

Let's give this a try.

[ehmaldonado_webrtc, 2017-01-26 15:16:24]

On 2017/01/26 15:15:41, ehmaldonado_webrtc wrote:
> On 2017/01/26 15:11:10, kjellander_webrtc wrote:
> > https://codereview.webrtc.org/2659493002/diff/40001/DEPS
> > File DEPS (right):
> > 
> > https://codereview.webrtc.org/2659493002/diff/40001/DEPS#newcode46
> > DEPS:46: 'src/ios':
> > On 2017/01/26 14:45:34, kthelgason wrote:
> > > Shouldn't this be down in `deps_os`? No need to pull it in all the time
> right?
> > 
> > Yes it seems to work. I was afraid it wouldn't due to references in Chromium
> > that were processed on all platforms (since the dir is always there in
> Chromium
> > since it's not a DEPS entry). But deps_os works (proven by the other
platform
> > trybots being green). Thanks for the suggestion.
> 
> Let's give this a try.

lgtm

[kjellander_webrtc, 2017-01-26 15:41:00]

Description was changed from

==========
Replace src/ios copy with DEPS mirror.

BUG=webrtc:6934
==========

to

==========
Replace src/ios copy with DEPS mirror.

BUG=webrtc:6934
TBR=henrika@webrtc.org
==========

[kjellander_webrtc, 2017-01-26 15:41:11]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org

[kjellander_webrtc, 2017-01-26 15:42:06]

TBR=henrika@webrtc.org for root owner approval.
I take full responsibility for if this breaks the bots - I'm afraid these kind
of change from dir to DEPS entry changes are not possible to use trybots for.

[kjellander_webrtc, 2017-01-26 15:42:41]

Description was changed from

==========
Replace src/ios copy with DEPS mirror.

BUG=webrtc:6934
TBR=henrika@webrtc.org
==========

to

==========
Replace src/ios copy with DEPS mirror.

BUG=webrtc:6934
R=ehmaldonado@webrtc.org
TBR=henrika@webrtc.org

Review-Url: https://codereview.webrtc.org/2659493002 .
Cr-Commit-Position: refs/heads/master@{#16300}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c3c82362f706216f9e1c31ef0...
==========

[kjellander_webrtc, 2017-01-26 15:42:53]

Committed patchset #5 (id:80001) manually as
c3c82362f706216f9e1c31ef0ca27531d32e0526 (presubmit successful).

[kjellander_webrtc, 2017-01-26 15:47:33]

On 2017/01/26 15:42:53, kjellander_webrtc wrote:
> Committed patchset #5 (id:80001) manually as
> c3c82362f706216f9e1c31ef0ca27531d32e0526 (presubmit successful).

*phew* it works on the commit bots. Now we got rid of this ugly duplicated code
and unlocks using a lot more of the Chromium iOS stuff!

[henrika_webrtc, 2017-01-26 15:54:16]

Don't know this area well enough to provide any extra useful insight.

lgtm