Android AppRTCMobile: Add setting for selecting H264 Baseline or High profile

Android AppRTCMobile: Add setting for selecting H264 Baseline or High profile

BUG=webrtc:6337
R=glaznev@webrtc.org

Review-Url: https://codereview.webrtc.org/2658243002 .
Cr-Commit-Position: refs/heads/master@{#16605}
Committed: https://chromium.googlesource.com/external/webrtc/+/070681328037b24dff85c83e21038c70384481b5

[magjed_webrtc, 2017-01-27 15:10:18]

Description was changed from

==========
Android AppRTCMobile: Add setting for selecting H264 Baseline or High profile

BUG=webrtc:6337
==========

to

==========
Android AppRTCMobile: Add setting for selecting H264 Baseline or High profile

BUG=webrtc:6337
==========

[magjed_webrtc, 2017-01-27 15:10:19]

magjed@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[magjed_webrtc, 2017-01-27 15:10:26]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 15:10:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-27 17:46:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 17:46:37]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-02-13 16:12:33]

Alex - please take a look.

[AlexG, 2017-02-13 20:51:15]

lgtm

[AlexG, 2017-02-13 20:51:23]

The CQ bit was checked by glaznev@webrtc.org

[commit-bot: I haz the power, 2017-02-13 20:51:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[AlexG, 2017-02-13 20:52:11]

The CQ bit was unchecked by glaznev@webrtc.org

[AlexG, 2017-02-13 20:52:57]

lgtm

https://codereview.webrtc.org/2658243002/diff/1/webrtc/examples/androidapp/sr...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/2658243002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:409:
PeerConnectionFactory.initializeFieldTrials(fieldTrials);
nit: worth to log fieldTrails value for debug purposes?

[magjed_webrtc, 2017-02-14 10:02:09]

https://codereview.webrtc.org/2658243002/diff/1/webrtc/examples/androidapp/sr...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/2658243002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:409:
PeerConnectionFactory.initializeFieldTrials(fieldTrials);
On 2017/02/13 20:52:57, AlexG wrote:
> nit: worth to log fieldTrails value for debug purposes?

Done.

[magjed_webrtc, 2017-02-14 10:02:17]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2017-02-14 10:02:18]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2658243002/#ps20001 (title:
"Log field trials")

[commit-bot: I haz the power, 2017-02-14 10:02:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-14 10:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 10:47:39]

Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/16194)

[magjed_webrtc, 2017-02-14 11:41:39]

Description was changed from

==========
Android AppRTCMobile: Add setting for selecting H264 Baseline or High profile

BUG=webrtc:6337
==========

to

==========
Android AppRTCMobile: Add setting for selecting H264 Baseline or High profile

BUG=webrtc:6337
R=glaznev@webrtc.org

Review-Url: https://codereview.webrtc.org/2658243002 .
Cr-Commit-Position: refs/heads/master@{#16605}
Committed:
https://chromium.googlesource.com/external/webrtc/+/070681328037b24dff85c83e2...
==========

[magjed_webrtc, 2017-02-14 11:41:41]

Committed patchset #2 (id:20001) manually as
070681328037b24dff85c83e21038c70384481b5 (presubmit successful).