Move more calls to webrtc::field_trial::FindFullName into ctor

Move more calls to webrtc::field_trial::FindFullName into ctor, thereby minimizing the non-trivial cost of repeated string comparisons.

BUG=webrtc:7059
Review-Url: https://codereview.webrtc.org/2657863002
Cr-Commit-Position: refs/heads/master@{#16378}
Committed: https://chromium.googlesource.com/external/webrtc/+/0fe1216c9c4cb7d1d60446f9b760d10d183ee0b4

[elad.alon_webrtc.org, 2017-01-25 18:17:16]

elad.alon@webrtc.org changed reviewers:
+ michaelt@webrtc.org, minyue@webrtc.org, solenberg@webrtc.org,
sprang@webrtc.org, stefan@webrtc.org

[elad.alon_webrtc.org, 2017-01-26 10:59:21]

Description was changed from

==========
Move more calls to webrtc::field_trial::FindFullName into ctor

BUG=
==========

to

==========
Move more calls to webrtc::field_trial::FindFullName into ctor

BUG=webrtc:7059
==========

[elad.alon_webrtc.org, 2017-01-26 11:00:01]

Description was changed from

==========
Move more calls to webrtc::field_trial::FindFullName into ctor

BUG=webrtc:7059
==========

to

==========
Move more calls to webrtc::field_trial::FindFullName into ctor, thereby
minimizing the non-trivial cost of repeated string comparisons.

BUG=webrtc:7059
==========

[stefan-webrtc, 2017-01-31 08:13:54]

lgtm

[minyue-webrtc, 2017-01-31 08:47:25]

lgtm

[sprang_webrtc, 2017-01-31 09:45:14]

lgtm

[elad.alon_webrtc.org, 2017-01-31 09:57:00]

The CQ bit was checked by elad.alon@webrtc.org

[commit-bot: I haz the power, 2017-01-31 09:57:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-31 09:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 09:58:34]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/16800)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/22227)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/20962)

[minyue-webrtc, 2017-01-31 11:48:06]

https://codereview.webrtc.org/2657863002/diff/20001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2657863002/diff/20001/webrtc/video/video_send_s...
webrtc/video/video_send_stream.cc:391: size_t overhead_bytes_per_packet,
Feels better if we keep it outside but add send_side_bwe_with_overhead as an
arg. Because it is a utility function (given all private vars, it is still
unable to calculate overhead rate)

[elad.alon_webrtc.org, 2017-01-31 12:18:40]

On 2017/01/31 11:48:06, minyue-webrtc wrote:
>
https://codereview.webrtc.org/2657863002/diff/20001/webrtc/video/video_send_s...
> File webrtc/video/video_send_stream.cc (right):
> 
>
https://codereview.webrtc.org/2657863002/diff/20001/webrtc/video/video_send_s...
> webrtc/video/video_send_stream.cc:391: size_t overhead_bytes_per_packet,
> Feels better if we keep it outside but add send_side_bwe_with_overhead as an
> arg. Because it is a utility function (given all private vars, it is still
> unable to calculate overhead rate)

Ended up just removing the call to the function when it's deemed not necessary,
rather than add an argument that would tell the function whether it should abort
early.

[minyue-webrtc, 2017-01-31 12:42:02]

lgtm % a nit

https://codereview.webrtc.org/2657863002/diff/40001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2657863002/diff/40001/webrtc/video/video_send_s...
webrtc/video/video_send_stream.cc:1246: uint32_t encoder_overhead_rate_bps = 0;
nit:

uint32_t encoder_overhead_rate_bps = send_side_bwe_with_overhead_ ? ... : 0;

[elad.alon_webrtc.org, 2017-01-31 12:55:11]

The CQ bit was checked by elad.alon@webrtc.org

[elad.alon_webrtc.org, 2017-01-31 12:55:11]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org,
stefan@webrtc.org, minyue@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2657863002/#ps60001 (title:
".")

[commit-bot: I haz the power, 2017-01-31 12:55:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-31 13:48:38]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485867311216840,
"parent_rev": "89f281c51ac979a2b545d23cfd3d37460f01fbe6", "commit_rev":
"0fe1216c9c4cb7d1d60446f9b760d10d183ee0b4"}

[commit-bot: I haz the power, 2017-01-31 13:48:41]

Description was changed from

==========
Move more calls to webrtc::field_trial::FindFullName into ctor, thereby
minimizing the non-trivial cost of repeated string comparisons.

BUG=webrtc:7059
==========

to

==========
Move more calls to webrtc::field_trial::FindFullName into ctor, thereby
minimizing the non-trivial cost of repeated string comparisons.

BUG=webrtc:7059

Review-Url: https://codereview.webrtc.org/2657863002
Cr-Commit-Position: refs/heads/master@{#16378}
Committed:
https://chromium.googlesource.com/external/webrtc/+/0fe1216c9c4cb7d1d60446f9b...
==========

[commit-bot: I haz the power, 2017-01-31 13:48:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/0fe1216c9c4cb7d1d60446f9b...