Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2657823004:
Only define NO_RETURN if undefined (Closed)
DescriptionOnly define NO_RETURN if undefined
WebRTC's NO_RETURN definition conflicts with WebKit's. This can be avoided by
only defining it if not already defined.
BUG=webrtc:7054
Review-Url: https://codereview.webrtc.org/2657823004
Cr-Commit-Position: refs/heads/master@{#16353}
Committed: https://chromium.googlesource.com/external/webrtc/+/a26330ac6f82c3e5f79dc63421ee93e806c9065e
Patch Set 1 #
Total comments: 1
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by agouaillard@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Webrtc's NO-RETURN definition conflicts with webkit's. BUG=7054 ========== to ========== Webrtc's NO-RETURN definition conflicts with webkit's. BUG=7054 ==========
agouaillard@gmail.com changed reviewers: + niklas.enbom@webrtc.org, tommi@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
For your kind review.
niklas.enbom@webrtc.org changed reviewers: + kjellander@webrtc.org
kjellander, can you take a look?
lgtm https://codereview.webrtc.org/2657823004/diff/1/webrtc/typedefs.h File webrtc/typedefs.h (right): https://codereview.webrtc.org/2657823004/diff/1/webrtc/typedefs.h#newcode101 webrtc/typedefs.h:101: #ifndef NO_RETURN Looks like NO_RETURN is only used in base/checks.* so an alternative approach could be to rename the macro to RTC_NO_RETURN
Description was changed from ========== Webrtc's NO-RETURN definition conflicts with webkit's. BUG=7054 ========== to ========== Only define NO_RETURN if undefined WebRTC's NO_RETURN definition conflicts with WebKit's. This can be avoided by only defining it if not already defined. BUG=webrtc:7054 ==========
lgtm. I altered the CL description to make it more clear (and changed NO-RETURN to NO_RETURN). Also note that the BUG= number needs to be prefixed with webrtc: to get correctly linked and posted into the bug upon submit.
The CQ bit was checked by tommi@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485763406533250, "parent_rev":
"2e6048461e72377c012706177b8dc4841919ddb3", "commit_rev":
"a26330ac6f82c3e5f79dc63421ee93e806c9065e"}
Message was sent while issue was closed.
Description was changed from ========== Only define NO_RETURN if undefined WebRTC's NO_RETURN definition conflicts with WebKit's. This can be avoided by only defining it if not already defined. BUG=webrtc:7054 ========== to ========== Only define NO_RETURN if undefined WebRTC's NO_RETURN definition conflicts with WebKit's. This can be avoided by only defining it if not already defined. BUG=webrtc:7054 Review-Url: https://codereview.webrtc.org/2657823004 Cr-Commit-Position: refs/heads/master@{#16353} Committed: https://chromium.googlesource.com/external/webrtc/+/a26330ac6f82c3e5f79dc6342... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/a26330ac6f82c3e5f79dc6342... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
