Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2657813003: Move Android tests under sdk/android. (Closed)

Created:
3 years, 10 months ago by sakal
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move Android tests under sdk/android. BUG=None Review-Url: https://codereview.webrtc.org/2657813003 Cr-Commit-Position: refs/heads/master@{#16323} Committed: https://chromium.googlesource.com/external/webrtc/+/b621c3f5e4dbaf979872657740a1f463212a7c55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -67 lines) Patch
M webrtc/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/androidjunit/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/androidjunit/src/org/webrtc/CameraEnumerationTest.java View 1 chunk +0 lines, -50 lines 0 comments Download
A + webrtc/sdk/android/tests/src/org/webrtc/CameraEnumerationTest.java View 2 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
sakal
PTAL
3 years, 10 months ago (2017-01-25 13:52:53 UTC) #3
kjellander_webrtc
lgtm assuming trybots are happy.
3 years, 10 months ago (2017-01-25 13:58:12 UTC) #4
magjed_webrtc
lgtm
3 years, 10 months ago (2017-01-25 18:32:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2657813003/1
3 years, 10 months ago (2017-01-26 08:16:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12698)
3 years, 10 months ago (2017-01-26 08:21:33 UTC) #13
sakal
Henrik, could you rubber stamp this please?
3 years, 10 months ago (2017-01-26 09:48:28 UTC) #15
henrika_webrtc
LGTM
3 years, 10 months ago (2017-01-27 12:18:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2657813003/1
3 years, 10 months ago (2017-01-27 12:18:54 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 13:15:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b621c3f5e4dbaf97987265774...

Powered by Google App Engine
This is Rietveld 408576698