Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2657783002: Remove "video_capture" from modules' public_deps. (Closed)

Created:
3 years, 11 months ago by jianjunz
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove "video_capture" from modules' public_deps. WebRTC standalone build may depend on "video_capture_internal_impl" instead of "video_capture". Including "video_capture" in public_deps leads to duplicated definition in this case. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2657783002 Cr-Commit-Position: refs/heads/master@{#16279} Committed: https://chromium.googlesource.com/external/webrtc/+/cc7213e2c0153d6b1a69ffa3ce421af2767f4fa2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
jianjunz
PTAL. Thanks.
3 years, 11 months ago (2017-01-25 06:40:38 UTC) #3
kjellander_webrtc
On 2017/01/25 06:40:38, jianjunz wrote: > PTAL. Thanks. You're right, thanks for you contribution. I ...
3 years, 11 months ago (2017-01-25 16:26:51 UTC) #5
kjellander_webrtc
On 2017/01/25 16:26:51, kjellander_webrtc wrote: > On 2017/01/25 06:40:38, jianjunz wrote: > > PTAL. Thanks. ...
3 years, 11 months ago (2017-01-25 16:26:58 UTC) #6
jianjunz
On 2017/01/25 16:26:51, kjellander_webrtc wrote: > On 2017/01/25 06:40:38, jianjunz wrote: > > PTAL. Thanks. ...
3 years, 11 months ago (2017-01-26 00:12:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2657783002/1
3 years, 11 months ago (2017-01-26 00:12:29 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 00:15:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/cc7213e2c0153d6b1a69ffa3c...

Powered by Google App Engine
This is Rietveld 408576698