AppRTCMobile links against framework target.

AppRTCMobile links against framework target.

BUG=None

Review-Url: https://codereview.webrtc.org/2656833002
Cr-Commit-Position: refs/heads/master@{#16287}
Committed: https://chromium.googlesource.com/external/webrtc/+/d3adbfb13c88cb4b58b79518b656a4cc4314bb9c

[kthelgason, 2017-01-25 15:34:34]

kthelgason@webrtc.org changed reviewers:
+ denicija@webrtc.org, magjed@webrtc.org

[kthelgason, 2017-01-25 15:34:34]

This CL makes the changes necessary for the AppRTCMobile target to build and
link with WebRTC.framework.

The next step is actually running the target on the bots to make sure it works,
but for now I've done so manually.

[magjed_webrtc, 2017-01-25 18:33:33]

lgtm!

[daniela-webrtc, 2017-01-26 07:44:24]

Thanks for adding this. lgtm... with one tiny question that you can answer if
you have time.

https://codereview.webrtc.org/2656833002/diff/1/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2656833002/diff/1/webrtc/sdk/BUILD.gn#newcode322
webrtc/sdk/BUILD.gn:322: "-install_name",
I'm not familiar with this flag. What is it suppose to do?

[kthelgason, 2017-01-26 08:31:48]

https://codereview.webrtc.org/2656833002/diff/1/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2656833002/diff/1/webrtc/sdk/BUILD.gn#newcode322
webrtc/sdk/BUILD.gn:322: "-install_name",
On 2017/01/26 07:44:24, denicija-webrtc wrote:
> I'm not familiar with this flag. What is it suppose to do?

In short, it has to do with how macOS loads dynamic libraries. Dylibs have a
load command that specifies their install_name, and this is what the application
that links against them will look for when loading them at runtime. The
application also has a load command specifying it's @rpath, where it will look
for libraries to load.

[kthelgason, 2017-01-26 08:31:53]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2017-01-26 08:32:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-26 09:14:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485419513126380, "parent_rev":
"8e775e16eba1c3d2983f24d3fcf59400f79b9783", "commit_rev":
"d3adbfb13c88cb4b58b79518b656a4cc4314bb9c"}

[commit-bot: I haz the power, 2017-01-26 09:14:07]

Description was changed from

==========
AppRTCMobile links against framework target.

BUG=None
==========

to

==========
AppRTCMobile links against framework target.

BUG=None

Review-Url: https://codereview.webrtc.org/2656833002
Cr-Commit-Position: refs/heads/master@{#16287}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d3adbfb13c88cb4b58b79518b...
==========

[commit-bot: I haz the power, 2017-01-26 09:14:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d3adbfb13c88cb4b58b79518b...