Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2656553002: Moving get_landmines.py (build/ -> tools-webrtc/) (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moving get_landmines.py (build/ -> tools-webrtc/) BUG=webrtc:7030 NOTRY=True Review-Url: https://codereview.webrtc.org/2656553002 Cr-Commit-Position: refs/heads/master@{#16227} Committed: https://chromium.googlesource.com/external/webrtc/+/ad452287b04060b01c9137ec6b22524401ce4e98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -62 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + tools-webrtc/get_landmines.py View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/build/get_landmines.py View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mbonadei
3 years, 11 months ago (2017-01-24 07:18:52 UTC) #2
kjellander_webrtc
lgtm since you've covered all the platforms with tryjobs, I think it's safe to use ...
3 years, 11 months ago (2017-01-24 07:54:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2656553002/1
3 years, 11 months ago (2017-01-24 07:59:33 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 08:01:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ad452287b04060b01c9137ec6...

Powered by Google App Engine
This is Rietveld 408576698