Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2655893003: Validate the build type argument value in function build_webrtc (Closed)

Created:
3 years, 11 months ago by VladimirTechMan
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, oprypin_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Validate the build type argument value in function build_webrtc BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2655893003 Cr-Commit-Position: refs/heads/master@{#16277} Committed: https://chromium.googlesource.com/external/webrtc/+/1a7f01c6d32842de15d128d959a904edb85e4ded

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/build/ios/build_ios_libs.sh View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
VladimirTechMan
3 years, 11 months ago (2017-01-25 21:34:39 UTC) #3
kjellander_webrtc
lgtm, although I suggest you don't spend more time on this as oprypin@ is looking ...
3 years, 11 months ago (2017-01-25 21:47:18 UTC) #4
VladimirTechMan
On 2017/01/25 21:47:18, kjellander_webrtc wrote: > lgtm, although I suggest you don't spend more time ...
3 years, 11 months ago (2017-01-25 22:26:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2655893003/1
3 years, 11 months ago (2017-01-25 22:27:21 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 22:30:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1a7f01c6d32842de15d128d95...

Powered by Google App Engine
This is Rietveld 408576698