Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 2655033002: Prioritize video packets when sending padding or preemptive retransmits. (Closed)

Created:
3 years, 10 months ago by stefan-webrtc
Modified:
3 years, 10 months ago
Reviewers:
philipel, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prioritize video packets when sending padding or preemptive retransmits. Video modules are added in reverse order to ensure that the padding order is the same as before, prioritizing high resolution streams. BUG=webrtc:7043 Review-Url: https://codereview.webrtc.org/2655033002 Cr-Commit-Position: refs/heads/master@{#16329} Committed: https://chromium.googlesource.com/external/webrtc/+/16b02211a938c2320ef458425bcd4f657328ba52

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments addressed. #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M webrtc/modules/pacing/packet_router.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M webrtc/modules/pacing/packet_router_unittest.cc View 1 chunk +14 lines, -11 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
stefan-webrtc
3 years, 10 months ago (2017-01-25 16:12:34 UTC) #2
philipel
lgtm
3 years, 10 months ago (2017-01-26 12:14:03 UTC) #7
mflodman
https://codereview.webrtc.org/2655033002/diff/1/webrtc/modules/pacing/packet_router.cc File webrtc/modules/pacing/packet_router.cc (right): https://codereview.webrtc.org/2655033002/diff/1/webrtc/modules/pacing/packet_router.cc#newcode73 webrtc/modules/pacing/packet_router.cc:73: for (RtpRtcp* module : rtp_modules_) { I think it ...
3 years, 10 months ago (2017-01-26 13:01:40 UTC) #8
stefan-webrtc
https://codereview.webrtc.org/2655033002/diff/1/webrtc/modules/pacing/packet_router.cc File webrtc/modules/pacing/packet_router.cc (right): https://codereview.webrtc.org/2655033002/diff/1/webrtc/modules/pacing/packet_router.cc#newcode73 webrtc/modules/pacing/packet_router.cc:73: for (RtpRtcp* module : rtp_modules_) { On 2017/01/26 13:01:40, ...
3 years, 10 months ago (2017-01-27 11:52:38 UTC) #9
mflodman
One nit, then LGTM. https://codereview.webrtc.org/2655033002/diff/20001/webrtc/video/video_send_stream.cc File webrtc/video/video_send_stream.cc (right): https://codereview.webrtc.org/2655033002/diff/20001/webrtc/video/video_send_stream.cc#newcode804 webrtc/video/video_send_stream.cc:804: for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) ...
3 years, 10 months ago (2017-01-27 12:57:59 UTC) #10
stefan-webrtc
.
3 years, 10 months ago (2017-01-27 13:04:28 UTC) #11
stefan-webrtc
.
3 years, 10 months ago (2017-01-27 13:05:12 UTC) #12
stefan-webrtc
https://codereview.webrtc.org/2655033002/diff/20001/webrtc/video/video_send_stream.cc File webrtc/video/video_send_stream.cc (right): https://codereview.webrtc.org/2655033002/diff/20001/webrtc/video/video_send_stream.cc#newcode804 webrtc/video/video_send_stream.cc:804: for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) { On 2017/01/27 12:57:59, ...
3 years, 10 months ago (2017-01-27 13:05:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2655033002/60001
3 years, 10 months ago (2017-01-27 13:05:45 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 15:12:21 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/16b02211a938c2320ef458425...

Powered by Google App Engine
This is Rietveld 408576698