Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2654813002:
Add QP for libvpx VP9 decoder. (Closed)
|
Created:
3 years, 11 months ago by sakal Modified:
3 years, 10 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd QP for libvpx VP9 decoder.
Also adds a basic unit test for VP9 implementation.
BUG=webrtc:6541
Review-Url: https://codereview.webrtc.org/2654813002
Cr-Commit-Position: refs/heads/master@{#16795}
Committed: https://chromium.googlesource.com/external/webrtc/+/7adadb1fdfbd6c9ff38162d9ecae7d9213d99653
Patch Set 1 : Add a unit test. #Patch Set 2 : Cleanup. #
Messages
Total messages: 38 (32 generated)
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_ubsan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/9438)
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_more_configs on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Patchset #4 (id:60001) has been deleted
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_arm on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm/builds/6058) linux_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/22375)
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #1 (id:120001) has been deleted
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #2 (id:160001) has been deleted
Description was changed from ========== Add QP for libvpx VP9 decoder. BUG=webrtc:6541 ========== to ========== Add QP for libvpx VP9 decoder. BUG=webrtc:6541 ==========
sakal@webrtc.org changed reviewers: + stefan@webrtc.org
Description was changed from ========== Add QP for libvpx VP9 decoder. BUG=webrtc:6541 ========== to ========== Add QP for libvpx VP9 decoder. Also adds a basic unit test for VP9 implementation. BUG=webrtc:6541 ==========
PTAL
Good stuff, thanks for adding the tests! lgtm
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 180001, "attempt_start_ts": 1487845603158330,
"parent_rev": "1e46434e7ef90da1aebaf28cb7ac0d674c857e7a", "commit_rev":
"7adadb1fdfbd6c9ff38162d9ecae7d9213d99653"}
Message was sent while issue was closed.
Description was changed from ========== Add QP for libvpx VP9 decoder. Also adds a basic unit test for VP9 implementation. BUG=webrtc:6541 ========== to ========== Add QP for libvpx VP9 decoder. Also adds a basic unit test for VP9 implementation. BUG=webrtc:6541 Review-Url: https://codereview.webrtc.org/2654813002 Cr-Commit-Position: refs/heads/master@{#16795} Committed: https://chromium.googlesource.com/external/webrtc/+/7adadb1fdfbd6c9ff38162d9e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:180001) as https://chromium.googlesource.com/external/webrtc/+/7adadb1fdfbd6c9ff38162d9e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
