Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2654773002: Reland of Moving webrtc.gni up one level from build/ (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, perkj_webrtc, aluebs-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247} Committed: https://chromium.googlesource.com/external/webrtc/+/9aa3f0a2006dfc7278e0c93cd073d4bbb190b796

Patch Set 1 #

Patch Set 2 : Adding temporary file to avoid chromium breakage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -360 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D webrtc/build/webrtc.gni View 1 2 chunks +2 lines, -318 lines 0 comments Download
M webrtc/call/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_coding.gni View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_mixer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/media_file/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/stats/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fuzzers/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/webrtc.gni View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Reland of Moving webrtc.gni up one level from build/
3 years, 11 months ago (2017-01-24 13:17:09 UTC) #1
kjellander_webrtc
On 2017/01/24 13:17:09, mbonadei wrote: > Created Reland of Moving webrtc.gni up one level from ...
3 years, 11 months ago (2017-01-24 14:00:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2654773002/300001
3 years, 11 months ago (2017-01-24 14:58:11 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 14:58:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:300001) as
https://chromium.googlesource.com/external/webrtc/+/9aa3f0a2006dfc7278e0c93cd...

Powered by Google App Engine
This is Rietveld 408576698