Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2654633002: Remove svc_context.h include (Closed)

Created:
3 years, 11 months ago by Johann
Modified:
3 years, 11 months ago
Reviewers:
åsapersson, marpan2, Stefan
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove svc_context.h include Features in this header rely on configuring libvpx with --enable-experimental and --enable-spatial-svc This was mistakenly used to get access to vpx_svc_extra_cfg_t through SvcInternal_t. BUG=chromium:575651 https://bugzilla.mozilla.org/show_bug.cgi?id=1332664 Review-Url: https://codereview.webrtc.org/2654633002 Cr-Commit-Position: refs/heads/master@{#16308} Committed: https://chromium.googlesource.com/external/webrtc/+/8225c405c4a257c2312cd00125da650c13bff309

Patch Set 1 #

Patch Set 2 : remove mistaken misdirection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 5 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
Johann
This looks like it'll end up going green. May I haz code review plz?
3 years, 11 months ago (2017-01-26 20:12:21 UTC) #10
marpan2
lgtm
3 years, 11 months ago (2017-01-26 20:19:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2654633002/20001
3 years, 11 months ago (2017-01-26 20:23:33 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 21:23:48 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8225c405c4a257c2312cd0012...

Powered by Google App Engine
This is Rietveld 408576698