Enable Android H264 High profile decoder

Enable Android H264 High profile decoder

Based on Magnus's
https://codereview.webrtc.org/2646423002/

BUG=webrtc:6337
Review-Url: https://codereview.webrtc.org/2654003005
Cr-Commit-Position: refs/heads/master@{#16332}
Committed: https://chromium.googlesource.com/external/webrtc/+/0c1d060b24ee7ccf0231970a71baf1aaed089c26

[AlexG, 2017-01-26 01:22:39]

glaznev@webrtc.org changed reviewers:
+ magjed@webrtc.org

[AlexG, 2017-01-26 01:22:39]

PTAL

[magjed_webrtc, 2017-01-26 19:05:37]

Looks good overall, but I don't think we should add (unconstrained) High
profile. Interop with iOS will not work unless we add Constrained High profile.
B frames is not something we want to use in WebRTC anyway.

https://codereview.webrtc.org/2654003005/diff/1/webrtc/examples/androidapp/sr...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/2654003005/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:79:
private static final String VIDEO_H264_HIGH_PROFILE_HW_ENCODER_FIELDTRIAL =
This is for both encoding and decoding, so I would just call it
VIDEO_H264_HIGH_PROFILE_FIELDTRIAL.

https://codereview.webrtc.org/2654003005/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2654003005/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:145: // List of
supported HW high profile H.264 encoders.
We will need something like this when we enable High profile encoding, but right
now we only enable High profile decoding, so I think we should move this check
to the decoder in this CL.

[AlexG, 2017-01-27 01:08:39]

https://codereview.webrtc.org/2654003005/diff/1/webrtc/examples/androidapp/sr...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/2654003005/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:79:
private static final String VIDEO_H264_HIGH_PROFILE_HW_ENCODER_FIELDTRIAL =
On 2017/01/26 19:05:37, magjed_webrtc wrote:
> This is for both encoding and decoding, so I would just call it
> VIDEO_H264_HIGH_PROFILE_FIELDTRIAL.

Done.

https://codereview.webrtc.org/2654003005/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2654003005/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:145: // List of
supported HW high profile H.264 encoders.
On 2017/01/26 19:05:37, magjed_webrtc wrote:
> We will need something like this when we enable High profile encoding, but
right
> now we only enable High profile decoding, so I think we should move this check
> to the decoder in this CL.

Done.

[magjed_webrtc, 2017-01-27 09:34:43]

Description was changed from

==========
Enable Android H264 High profile decoder

Based on Magnus's
https://codereview.webrtc.org/2646423002/

BUG=None
==========

to

==========
Enable Android H264 High profile decoder

Based on Magnus's
https://codereview.webrtc.org/2646423002/

BUG=webrtc:6337
==========

[magjed_webrtc, 2017-01-27 09:35:11]

lgtm

https://codereview.webrtc.org/2654003005/diff/20001/webrtc/sdk/android/src/jn...
File webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/2654003005/diff/20001/webrtc/sdk/android/src/jn...
webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc:1220: bool
is_h264_high_porfile_hw_supported = false;
nit spelling: profile

[AlexG, 2017-01-27 19:21:49]

https://codereview.webrtc.org/2654003005/diff/20001/webrtc/sdk/android/src/jn...
File webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/2654003005/diff/20001/webrtc/sdk/android/src/jn...
webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc:1220: bool
is_h264_high_porfile_hw_supported = false;
On 2017/01/27 09:35:11, magjed_webrtc wrote:
> nit spelling: profile

Done.

[AlexG, 2017-01-27 19:22:09]

The CQ bit was checked by glaznev@webrtc.org

[AlexG, 2017-01-27 19:22:10]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2654003005/#ps40001 (title:
"Fix typo")

[commit-bot: I haz the power, 2017-01-27 19:22:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-27 20:24:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485544929899130,
"parent_rev": "62a5dd218144645539b1a525052f8fc87a1320ec", "commit_rev":
"0c1d060b24ee7ccf0231970a71baf1aaed089c26"}

[commit-bot: I haz the power, 2017-01-27 20:24:27]

Description was changed from

==========
Enable Android H264 High profile decoder

Based on Magnus's
https://codereview.webrtc.org/2646423002/

BUG=webrtc:6337
==========

to

==========
Enable Android H264 High profile decoder

Based on Magnus's
https://codereview.webrtc.org/2646423002/

BUG=webrtc:6337

Review-Url: https://codereview.webrtc.org/2654003005
Cr-Commit-Position: refs/heads/master@{#16332}
Committed:
https://chromium.googlesource.com/external/webrtc/+/0c1d060b24ee7ccf0231970a7...
==========

[commit-bot: I haz the power, 2017-01-27 20:24:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/0c1d060b24ee7ccf0231970a7...