Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2653703004: Added api/webrtcsdp.h forwarding header to work around upstream projects. (Closed)

Created:
3 years, 11 months ago by ossu
Modified:
3 years, 11 months ago
Reviewers:
tommi, aleloi
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added api/webrtcsdp.h forwarding header to work around upstream projects. NOTRY=true # Small change, in a hurry and msan is being slow TBR=tommi@webrtc.org BUG=webrtc:5883 Review-Url: https://codereview.webrtc.org/2653703004 Cr-Commit-Position: refs/heads/master@{#16248} Committed: https://chromium.googlesource.com/external/webrtc/+/a388310af26bd713e0af252e2955717651c679f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/api/webrtcsdp.h View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
ossu
Added another forwarding header to work around problems with downstream projects. Will reach out to ...
3 years, 11 months ago (2017-01-24 14:29:30 UTC) #4
aleloi
lgtm
3 years, 11 months ago (2017-01-24 14:31:01 UTC) #5
ossu
+tommi -kjellander Realized I was missing an api/ owner as reviewer.
3 years, 11 months ago (2017-01-24 14:50:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2653703004/1
3 years, 11 months ago (2017-01-24 15:04:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2653703004/1
3 years, 11 months ago (2017-01-24 15:11:44 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/a388310af26bd713e0af252e2955717651c679f6
3 years, 11 months ago (2017-01-24 15:14:03 UTC) #18
tommi
3 years, 11 months ago (2017-01-24 17:27:49 UTC) #19
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698