Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2653593003: Removing unused code from webrtc/build (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing unused code from webrtc/build First step in moving the content of webrtc/build up one level. BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2653593003 Cr-Commit-Position: refs/heads/master@{#16219} Committed: https://chromium.googlesource.com/external/webrtc/+/cb893ee6346f27e7e660578c802bbe455fcf9102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -125 lines) Patch
D webrtc/build/generate_srcjar.py View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/build/google_play_services_download.py View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/build/no_op.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
mbonadei
Let's get started at moving stuff in "webrtc/build" up of one level. This CL only ...
3 years, 11 months ago (2017-01-23 10:53:36 UTC) #2
mbonadei
On 2017/01/23 10:53:36, mbonadei wrote: > Let's get started at moving stuff in "webrtc/build" up ...
3 years, 11 months ago (2017-01-23 11:43:52 UTC) #3
kjellander_webrtc
lgtm
3 years, 11 months ago (2017-01-23 12:02:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2653593003/1
3 years, 11 months ago (2017-01-23 12:09:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/17895) win_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 11 months ago (2017-01-23 12:09:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2653593003/1
3 years, 11 months ago (2017-01-23 12:13:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/15441) win_rel on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 11 months ago (2017-01-23 12:14:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2653593003/1
3 years, 11 months ago (2017-01-23 16:10:03 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 16:49:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/cb893ee6346f27e7e660578c8...

Powered by Google App Engine
This is Rietveld 408576698