Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issue 2653343004: Add new step graph type to event log visualization tool (Closed)

Created:
3 years, 11 months ago by terelius
Modified:
3 years, 10 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add new step graph type to event log visualization tool. Currently used for bitrate estimate and accumulated packet count, but could in general be used for any metric that is piecewise constant. BUG=None Review-Url: https://codereview.webrtc.org/2653343004 Cr-Commit-Position: refs/heads/master@{#16399} Committed: https://chromium.googlesource.com/external/webrtc/+/77f0580f83c4ee0b85f71e64b227711c26b2ecab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M webrtc/tools/event_log_visualizer/analyzer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/tools/event_log_visualizer/chart.proto View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/plot_base.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/plot_protobuf.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/tools/event_log_visualizer/plot_python.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
terelius
3 years, 11 months ago (2017-01-26 11:46:00 UTC) #4
philipel
lgtm
3 years, 10 months ago (2017-01-30 09:38:42 UTC) #7
terelius
stefan, do you have any comments?
3 years, 10 months ago (2017-02-01 13:40:01 UTC) #8
stefan-webrtc
lgtm
3 years, 10 months ago (2017-02-01 13:51:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2653343004/1
3 years, 10 months ago (2017-02-01 13:52:25 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 14:34:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/77f0580f83c4ee0b85f71e64b...

Powered by Google App Engine
This is Rietveld 408576698