Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2652893015: Rename adaptation api methods, extended vie_encoder unit test. (Closed)

Created:
3 years, 10 months ago by sprang_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename adaptation api methods, extended vie_encoder unit test. Use AdaptDown/AdaptUp instead of ScaleDown/ScaleUp, since we may want to adapt using other means than resolution. Also, extend vie_encoder with unit test that actually uses frames scaled to resolution as determined by VideoAdapter, since that seems to be the default implementation. BUG=webrtc:4172 Review-Url: https://codereview.webrtc.org/2652893015 Cr-Commit-Position: refs/heads/master@{#16402} Committed: https://chromium.googlesource.com/external/webrtc/+/b1ca073db43f8fdcb715d5642d5aa7da7582eb0d

Patch Set 1 #

Total comments: 8

Patch Set 2 : Cleanup #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase, again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -114 lines) Patch
M webrtc/modules/video_coding/utility/quality_scaler.h View 4 chunks +16 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler_unittest.cc View 1 5 chunks +29 lines, -29 lines 0 comments Download
M webrtc/test/frame_generator.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/test/frame_generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/overuse_frame_detector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/overuse_frame_detector_unittest.cc View 8 chunks +22 lines, -22 lines 0 comments Download
M webrtc/video/vie_encoder.h View 3 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 3 13 chunks +24 lines, -20 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 1 2 3 9 chunks +105 lines, -12 lines 0 comments Download

Messages

Total messages: 30 (19 generated)
sprang_webrtc
This CL is in preparation of a cpu adaptation mode for the main-resolution setting. I ...
3 years, 10 months ago (2017-01-27 14:18:52 UTC) #8
nisse-webrtc
LGTM. Do the suggested additional renames if you think they make sense. And you need ...
3 years, 10 months ago (2017-01-30 09:16:45 UTC) #9
sprang_webrtc
+stefan, need an owner for webrtc/test https://codereview.webrtc.org/2652893015/diff/1/webrtc/modules/video_coding/utility/quality_scaler.cc File webrtc/modules/video_coding/utility/quality_scaler.cc (right): https://codereview.webrtc.org/2652893015/diff/1/webrtc/modules/video_coding/utility/quality_scaler.cc#newcode42 webrtc/modules/video_coding/utility/quality_scaler.cc:42: const AdaptationObserverInterface::AdaptReason scale_reason_ ...
3 years, 10 months ago (2017-01-30 09:55:06 UTC) #11
nisse-webrtc
https://codereview.webrtc.org/2652893015/diff/1/webrtc/modules/video_coding/utility/quality_scaler.cc File webrtc/modules/video_coding/utility/quality_scaler.cc (right): https://codereview.webrtc.org/2652893015/diff/1/webrtc/modules/video_coding/utility/quality_scaler.cc#newcode42 webrtc/modules/video_coding/utility/quality_scaler.cc:42: const AdaptationObserverInterface::AdaptReason scale_reason_ = On 2017/01/30 09:55:05, språng wrote: ...
3 years, 10 months ago (2017-01-30 10:07:13 UTC) #12
sprang_webrtc
ping stefan
3 years, 10 months ago (2017-01-31 11:28:15 UTC) #13
sprang_webrtc
ping stefan
3 years, 10 months ago (2017-01-31 11:28:15 UTC) #14
stefan-webrtc
LGTM for webrtc/test
3 years, 10 months ago (2017-01-31 18:04:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2652893015/20001
3 years, 10 months ago (2017-02-01 10:14:49 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12892)
3 years, 10 months ago (2017-02-01 10:18:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2652893015/60001
3 years, 10 months ago (2017-02-01 15:57:16 UTC) #27
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 16:38:16 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/b1ca073db43f8fdcb715d5642...

Powered by Google App Engine
This is Rietveld 408576698