Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2652763005: Adding deadbeef@webrtc.org to webrtc/base/OWNERS. (Closed)

Created:
3 years, 11 months ago by Taylor Brandstetter
Modified:
3 years, 11 months ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding deadbeef@webrtc.org to webrtc/base/OWNERS. Also removing jiayl@webrtc.org, who's no longer working on webrtc. BUG=None Review-Url: https://codereview.webrtc.org/2652763005 Cr-Commit-Position: refs/heads/master@{#16253} Committed: https://chromium.googlesource.com/external/webrtc/+/ed111dad4d262a61e09ebf05e075e3d922d968cb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing jiayl@webrtc.org (no longer working on webrtc) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Taylor Brandstetter
tommi: Would you be comfortable with me becoming an owner of base/? Just wanted to ...
3 years, 11 months ago (2017-01-24 02:05:13 UTC) #2
tommi
Yes. Lgtm with one request. For larger changes let's stay in sync with owners in ...
3 years, 11 months ago (2017-01-24 10:32:16 UTC) #3
pthatcher1
lgtm
3 years, 11 months ago (2017-01-24 21:07:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2652763005/20001
3 years, 11 months ago (2017-01-24 21:10:18 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/ed111dad4d262a61e09ebf05e075e3d922d968cb
3 years, 11 months ago (2017-01-24 22:17:17 UTC) #11
Taylor Brandstetter
3 years, 11 months ago (2017-01-25 01:19:28 UTC) #12
Message was sent while issue was closed.
https://codereview.webrtc.org/2652763005/diff/1/webrtc/base/OWNERS
File webrtc/base/OWNERS (right):

https://codereview.webrtc.org/2652763005/diff/1/webrtc/base/OWNERS#newcode4
webrtc/base/OWNERS:4: jiayl@webrtc.org
On 2017/01/24 10:32:16, tommi (webrtc) wrote:
> Remove?

Done.

Powered by Google App Engine
This is Rietveld 408576698