Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2652713002: video_loopback: fall back to fake capturer if we can't open camera. (Closed)

Created:
3 years, 11 months ago by sprang_webrtc
Modified:
3 years, 11 months ago
Reviewers:
ilnik
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

video_loopback: fall back to fake capturer if we can't open camera. Test manually, since it's a manual test. BUG=webrtc:7036 Review-Url: https://codereview.webrtc.org/2652713002 Cr-Commit-Position: refs/heads/master@{#16218} Committed: https://chromium.googlesource.com/external/webrtc/+/1bed2e486ee699ff8e34378aaf327592612bf089

Patch Set 1 #

Total comments: 2

Patch Set 2 : dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M webrtc/video/video_quality_test.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sprang_webrtc
3 years, 11 months ago (2017-01-23 15:51:59 UTC) #2
ilnik
https://codereview.webrtc.org/2652713002/diff/1/webrtc/video/video_quality_test.cc File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2652713002/diff/1/webrtc/video/video_quality_test.cc#newcode1258 webrtc/video/video_quality_test.cc:1258: << ".yuv. Is this resource file present?"; Please check ...
3 years, 11 months ago (2017-01-23 15:55:42 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/2652713002/diff/1/webrtc/video/video_quality_test.cc File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2652713002/diff/1/webrtc/video/video_quality_test.cc#newcode1258 webrtc/video/video_quality_test.cc:1258: << ".yuv. Is this resource file present?"; On 2017/01/23 ...
3 years, 11 months ago (2017-01-23 15:57:52 UTC) #4
ilnik
lgtm LGTM
3 years, 11 months ago (2017-01-23 15:58:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2652713002/20001
3 years, 11 months ago (2017-01-23 15:59:01 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 16:46:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1bed2e486ee699ff8e34378aa...

Powered by Google App Engine
This is Rietveld 408576698