Minor cleanup: Removing unused variable

Removing unused variable OUTPUT_LIB

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2652553004
Cr-Commit-Position: refs/heads/master@{#16255}
Committed: https://chromium.googlesource.com/external/webrtc/+/eaae505d0201e93f137b19efd89d78c02d80ea54

[VladimirTechMan, 2017-01-24 05:40:48]

Description was changed from

==========
Minor cleanup: Removing unused variable
==========

to

==========
Removing unused variable OUTPUT_LIB

Just a minor cleanup inside build_ios_libs.sh
==========

[VladimirTechMan, 2017-01-24 05:40:48]

vladimirtechman@gmail.com changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-01-24 07:56:42]

Description was changed from

==========
Removing unused variable OUTPUT_LIB

Just a minor cleanup inside build_ios_libs.sh
==========

to

==========
Removing unused variable OUTPUT_LIB

BUG=webrtc:5085
NOTRY=True
==========

[kjellander_webrtc, 2017-01-24 07:57:02]

lgtm, I added BUG=webrtc:5085 and NOTRY=True for you.

[VladimirTechMan, 2017-01-24 18:34:04]

On 2017/01/24 07:57:02, kjellander_webrtc wrote:
> lgtm, I added BUG=webrtc:5085 and NOTRY=True for you.

Okay, thanks. Honestly, I was not sure if a bug report was absolutely necessary
for such minor cleanups – from the rules posted at webrtc.org it did not sound
exactly that way; or I mis-interpreted, possibly. In any case, my miss. Then,
let me create a new bug and link it to this patch. As this particular code
change is not specifically related to the iOS bitcode support, linking it to
that original bug does not make my technical mind feel more comfortable than not
linking it to any reported bug. :-) I will open a new one and update this issue.

Thanks again!

[kjellander_webrtc, 2017-01-24 21:45:36]

On 2017/01/24 18:34:04, VladimirTechMan wrote:
> On 2017/01/24 07:57:02, kjellander_webrtc wrote:
> > lgtm, I added BUG=webrtc:5085 and NOTRY=True for you.
> 
> Okay, thanks. Honestly, I was not sure if a bug report was absolutely
necessary
> for such minor cleanups – from the rules posted at http://webrtc.org it did
not sound
> exactly that way; or I mis-interpreted, possibly. In any case, my miss. Then,
> let me create a new bug and link it to this patch. As this particular code
> change is not specifically related to the iOS bitcode support, linking it to
> that original bug does not make my technical mind feel more comfortable than
not
> linking it to any reported bug. :-) I will open a new one and update this
issue.
> 
> Thanks again!

You're right that a BUG= reference is not needed for everything (but applies to
most cases). I saw this as an after-the-fact cleanup since you recently changed
webrtc/build/ios/build_ios_libs.sh. Sorry for aggressively changing your CL and
feel free to set BUG=None if you wish to. There's no need to file another bug
just for this - that's just silly.

[VladimirTechMan, 2017-01-25 00:04:02]

On 2017/01/24 21:45:36, kjellander_webrtc wrote:
> On 2017/01/24 18:34:04, VladimirTechMan wrote:
> > On 2017/01/24 07:57:02, kjellander_webrtc wrote:
> > > lgtm, I added BUG=webrtc:5085 and NOTRY=True for you.
> > 
> > Okay, thanks. Honestly, I was not sure if a bug report was absolutely
> necessary
> > for such minor cleanups – from the rules posted at http://webrtc.org it did
> not sound
> > exactly that way; or I mis-interpreted, possibly. In any case, my miss.
Then,
> > let me create a new bug and link it to this patch. As this particular code
> > change is not specifically related to the iOS bitcode support, linking it to
> > that original bug does not make my technical mind feel more comfortable than
> not
> > linking it to any reported bug. :-) I will open a new one and update this
> issue.
> > 
> > Thanks again!
> 
> You're right that a BUG= reference is not needed for everything (but applies
to
> most cases). I saw this as an after-the-fact cleanup since you recently
changed
> webrtc/build/ios/build_ios_libs.sh. Sorry for aggressively changing your CL
and
> feel free to set BUG=None if you wish to. There's no need to file another bug
> just for this - that's just silly.

Alright. Thanks for the quick follow-up and the clarification. In that case, I
will not file a new bug – I am glad to know we are on the same page here. But I
will set BUG=None explicitly for this and any other similar situations in the
future; that will make things more explicit, which is good, I think. Appreciate
your note to me on that part.

[VladimirTechMan, 2017-01-25 00:04:27]

Description was changed from

==========
Removing unused variable OUTPUT_LIB

BUG=webrtc:5085
NOTRY=True
==========

to

==========
Removing unused variable OUTPUT_LIB

BUG=None
NOTRY=True
==========

[VladimirTechMan, 2017-01-25 00:05:19]

The CQ bit was checked by vladimirtechman@gmail.com

[commit-bot: I haz the power, 2017-01-25 00:05:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 00:08:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485302719117000, "parent_rev":
"0dabfbfd895add37ea367017777b9adbb43f9313", "commit_rev":
"eaae505d0201e93f137b19efd89d78c02d80ea54"}

[commit-bot: I haz the power, 2017-01-25 00:08:03]

Description was changed from

==========
Removing unused variable OUTPUT_LIB

BUG=None
NOTRY=True
==========

to

==========
Removing unused variable OUTPUT_LIB

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2652553004
Cr-Commit-Position: refs/heads/master@{#16255}
Committed:
https://chromium.googlesource.com/external/webrtc/+/eaae505d0201e93f137b19efd...
==========

[commit-bot: I haz the power, 2017-01-25 00:08:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/eaae505d0201e93f137b19efd...