Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2652043005: Reland of Make the new jitter buffer the default jitter buffer. (Closed)

Created:
3 years, 11 months ago by philipel
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Make the new jitter buffer the default jitter buffer. (patchset #1 id:1 of https://codereview.webrtc.org/2638423003/ ) Reason for revert: Bugfixes related to the new jitter buffer has landed. Original issue's description: > Revert of Make the new jitter buffer the default jitter buffer. (patchset #2 id:230001 of https://codereview.webrtc.org/2642753002/ ) > > Reason for revert: > Breaks tests downstream. > > Original issue's description: > > Reland of Make the new jitter buffer the default jitter buffer. (patchset #1 id:1 of https://codereview.chromium.org/2632123005/ ) > > > > Reason for revert: > > Fix in this CL: https://codereview.chromium.org/2640793003/ > > > > Original issue's description: > > > Revert of Make the new jitter buffer the default jitter buffer. (patchset #7 id:120001 of https://codereview.chromium.org/2627463004/ ) > > > > > > Reason for revert: > > > Breaks android bots. > > > > > > Original issue's description: > > > > Make the new jitter buffer the default jitter buffer. > > > > > > > > This CL contains only the changes necessary to make the switch to the new jitter > > > > buffer, clean up will be done in follow up CLs. > > > > > > > > In this CL: > > > > - Removed the WebRTC-NewVideoJitterBuffer experiment and made the > > > > new video jitter buffer the default one. > > > > - Moved WebRTC.Video.KeyFramesReceivedInPermille and > > > > WebRTC.Video.JitterBufferDelayInMs to the ReceiveStatisticsProxy. > > > > > > > > BUG=webrtc:5514 > > > > > > > > Review-Url: https://codereview.webrtc.org/2627463004 > > > > Cr-Commit-Position: refs/heads/master@{#16114} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/0f0763d86d5d4e7f27e8dece02560e39c6da97d6 > > > > > > TBR=stefan@webrtc.org,terelius@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:5514 > > > > > > Review-Url: https://codereview.webrtc.org/2632123005 > > > Cr-Commit-Position: refs/heads/master@{#16117} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/c08c191f7d206dc0de945185370d18f29d556931 > > > > TBR=stefan@webrtc.org,terelius@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:5514 > > > > Review-Url: https://codereview.webrtc.org/2642753002 > > Cr-Commit-Position: refs/heads/master@{#16149} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f20dd0014d1cfc8a2e859a9e177e7fe2b21274ca > > TBR=stefan@webrtc.org,terelius@webrtc.org,philipel@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5514 > > Review-Url: https://codereview.webrtc.org/2638423003 > Cr-Commit-Position: refs/heads/master@{#16159} > Committed: https://chromium.googlesource.com/external/webrtc/+/04926b82641c426d764aa6e013e133db519129db TBR=stefan@webrtc.org,terelius@webrtc.org,kjellander@webrtc.org,kjellander@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5514 Review-Url: https://codereview.webrtc.org/2652043005 Cr-Commit-Position: refs/heads/master@{#16293} Committed: https://chromium.googlesource.com/external/webrtc/+/09d6ef00fc21b9f2c2c27e50e5e2952329ac4b4b

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -246 lines) Patch
M webrtc/modules/video_coding/frame_buffer2.h View 1 4 chunks +4 lines, -11 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 1 5 chunks +24 lines, -30 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2_unittest.cc View 1 6 chunks +61 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/timing.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 1 2 chunks +5 lines, -22 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 7 chunks +21 lines, -10 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 10 chunks +70 lines, -20 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 2 chunks +11 lines, -8 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 6 chunks +56 lines, -75 lines 0 comments Download
M webrtc/video/rtp_stream_receiver_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_receive_stream.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 6 chunks +27 lines, -40 lines 0 comments Download
M webrtc/video/video_stream_decoder.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/video/video_stream_decoder.cc View 1 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
philipel
Created Reland of Make the new jitter buffer the default jitter buffer.
3 years, 11 months ago (2017-01-26 10:04:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2652043005/1
3 years, 11 months ago (2017-01-26 10:04:25 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/builds/742) ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 11 months ago (2017-01-26 10:05:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2652043005/290001
3 years, 11 months ago (2017-01-26 10:20:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:290001) as https://chromium.googlesource.com/external/webrtc/+/09d6ef00fc21b9f2c2c27e50e5e2952329ac4b4b
3 years, 11 months ago (2017-01-26 10:59:37 UTC) #10
philipel
3 years, 11 months ago (2017-01-26 16:45:59 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:290001) has been created in
https://codereview.chromium.org/2656983002/ by philipel@webrtc.org.

The reason for reverting is: Breaks downstream bots.

Powered by Google App Engine
This is Rietveld 408576698