Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2651973002: Moving build/ios to tools-webrtc/ios (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, oprypin_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moving build/ios to tools-webrtc/ios BUG=webrtc:7030 NOTRY=True R=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2651973002 . Cr-Commit-Position: refs/heads/master@{#16295} Committed: https://chromium.googlesource.com/external/webrtc/+/ad524d66d3b6d7ad22f0d43b5128bb759ed351d9

Patch Set 1 #

Patch Set 2 : Fixing path to comply with the new location #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-31 lines, -1526 lines) Patch
A + tools-webrtc/ios/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest.xcodeproj/project.pbxproj View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest.xcodeproj/project.xcworkspace/contents.xcworkspacedata View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest/AppDelegate.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest/AppDelegate.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest/Assets.xcassets/AppIcon.appiconset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest/Base.lproj/LaunchScreen.storyboard View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest/Base.lproj/Main.storyboard View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest/Info.plist View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest/ViewController.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest/ViewController.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/PodTest/main.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/SDK/PodTest/Podfile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/build_ios_libs.sh View 1 1 chunk +1 line, -1 line 0 comments Download
A + tools-webrtc/ios/client.webrtc/iOS32_Debug.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/client.webrtc/iOS32_Release.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/client.webrtc/iOS32_Sim_Debug_(iOS_9.0).json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/client.webrtc/iOS64_Debug.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/client.webrtc/iOS64_Release.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_9.0).json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/generate_licenses.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/merge_ios_libs.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/no_op.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/objc_app.plist View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/tests/common_tests.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/tryserver.webrtc/ios_arm64_rel.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/tryserver.webrtc/ios_dbg.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/ios/tryserver.webrtc/ios_rel.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/build/ios/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest.xcodeproj/project.pbxproj View 1 chunk +0 lines, -387 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest.xcodeproj/project.xcworkspace/contents.xcworkspacedata View 1 chunk +0 lines, -7 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest/AppDelegate.h View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest/AppDelegate.m View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest/Assets.xcassets/AppIcon.appiconset/Contents.json View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest/Base.lproj/LaunchScreen.storyboard View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest/Base.lproj/Main.storyboard View 1 chunk +0 lines, -25 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest/Info.plist View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest/ViewController.h View 1 chunk +0 lines, -15 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest/ViewController.m View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/PodTest/main.m View 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/build/ios/SDK/PodTest/Podfile View 1 chunk +0 lines, -9 lines 0 comments Download
D webrtc/build/ios/build_ios_libs.sh View 1 1 chunk +0 lines, -213 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS32_Debug.json View 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS32_Release.json View 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS32_Sim_Debug_(iOS_9.0).json View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS64_Debug.json View 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS64_Release.json View 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS64_Sim_Debug_(iOS_9.0).json View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/build/ios/generate_licenses.py View 1 chunk +0 lines, -145 lines 0 comments Download
D webrtc/build/ios/merge_ios_libs.py View 1 chunk +0 lines, -124 lines 0 comments Download
D webrtc/build/ios/no_op.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D webrtc/build/ios/objc_app.plist View 1 chunk +0 lines, -24 lines 0 comments Download
D webrtc/build/ios/tests/common_tests.json View 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios_arm64_dbg.json View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios_arm64_rel.json View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios_dbg.json View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios_rel.json View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mbonadei
This is the Buildbot change: https://chromium-review.googlesource.com/432416
3 years, 11 months ago (2017-01-25 13:33:25 UTC) #2
kjellander_webrtc
On 2017/01/25 13:33:25, mbonadei wrote: > This is the Buildbot change: https://chromium-review.googlesource.com/432416 Awesome. I believe ...
3 years, 11 months ago (2017-01-25 13:56:40 UTC) #3
mbonadei
On 2017/01/25 13:56:40, kjellander_webrtc wrote: > On 2017/01/25 13:33:25, mbonadei wrote: > > This is ...
3 years, 11 months ago (2017-01-25 14:37:29 UTC) #4
kjellander_webrtc
On 2017/01/25 14:37:29, mbonadei wrote: > On 2017/01/25 13:56:40, kjellander_webrtc wrote: > > On 2017/01/25 ...
3 years, 11 months ago (2017-01-25 15:36:01 UTC) #5
mbonadei
On 2017/01/25 15:36:01, kjellander_webrtc wrote: > On 2017/01/25 14:37:29, mbonadei wrote: > > On 2017/01/25 ...
3 years, 11 months ago (2017-01-25 16:02:30 UTC) #6
kjellander_webrtc
lgtm, please just fire a few iOS trybots and use NOTRY=True (the try server is ...
3 years, 11 months ago (2017-01-25 16:12:15 UTC) #7
mbonadei
3 years, 11 months ago (2017-01-26 13:20:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ad524d66d3b6d7ad22f0d43b5128bb759ed351d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698