Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2651913002: Moving sanitizers from build/ to base/ (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tommi, henrika_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moving sanitizers from build/ to base/ We have to move the content of the 'webrtc/build/' directory up of one level (see crbug.com/611808 for further details). To avoid a collision with the DEPSed build/ at the top level we are moving all the content of 'webrtc/build/' to different locations (see webrtc:7030 for the suggested locations). BUG=webrtc:7030 NOTRY=True Review-Url: https://codereview.webrtc.org/2651913002 Cr-Commit-Position: refs/heads/master@{#16259} Committed: https://chromium.googlesource.com/external/webrtc/+/18e83ea598ae8ed0446169d35a34cc5d14dc71a0

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moving sanitizers from base/ to tools-webrtc/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -203 lines) Patch
M build_overrides/build.gni View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tools-webrtc/sanitizers/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/sanitizers/README View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/sanitizers/lsan_suppressions_webrtc.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/sanitizers/tsan_suppressions_webrtc.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/build/sanitizers/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/build/sanitizers/README View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/build/sanitizers/lsan_suppressions_webrtc.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
mbonadei
3 years, 11 months ago (2017-01-24 08:05:51 UTC) #3
kjellander_webrtc
+solenberg due to ongoing work on webrtc/base. Fredrik: do you think this is a good ...
3 years, 11 months ago (2017-01-24 08:11:37 UTC) #5
henrika_webrtc
I have not touched webrtc/base and am not comfortable in making this review. Adding Tommi ...
3 years, 11 months ago (2017-01-24 08:26:13 UTC) #6
the sun
On 2017/01/24 08:26:13, henrika_webrtc wrote: > I have not touched webrtc/base and am not comfortable ...
3 years, 11 months ago (2017-01-24 08:44:39 UTC) #8
mbonadei
On 2017/01/24 08:44:39, the sun (OOO until Jan 30th) wrote: > On 2017/01/24 08:26:13, henrika_webrtc ...
3 years, 11 months ago (2017-01-24 14:13:02 UTC) #10
kjellander_webrtc
lgtm
3 years, 11 months ago (2017-01-24 17:41:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2651913002/20001
3 years, 11 months ago (2017-01-25 07:02:17 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 07:04:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/18e83ea598ae8ed0446169d35...

Powered by Google App Engine
This is Rietveld 408576698