Chromium Code Reviews| Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLVideoView.h |
| diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLVideoView.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLVideoView.h |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..ce416fa43cc54541f35122a5fb57660124465ef5 |
| --- /dev/null |
| +++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLVideoView.h |
| @@ -0,0 +1,44 @@ |
| +/* |
| + * Copyright 2017 The WebRTC project authors. All Rights Reserved. |
| + * |
| + * Use of this source code is governed by a BSD-style license |
| + * that can be found in the LICENSE file in the root of the source |
| + * tree. An additional intellectual property rights grant can be found |
| + * in the file PATENTS. All contributing project authors may |
| + * be found in the AUTHORS file in the root of the source tree. |
| + */ |
| + |
| +#import <Foundation/Foundation.h> |
| +#import <MetalKit/MetalKit.h> |
| +#import "WebRTC/RTCVideoRenderer.h" |
| + |
| +NS_ASSUME_NONNULL_BEGIN |
| +RTC_EXPORT |
| + |
| +/** |
| + * RTCMTLVideoView is thin wrapper around MTKView. |
| + * |
| + * It has id<RTCVideoRenderer> property that renders video frames in the view's |
| + * bounds using Metal. |
| + */ |
| +@interface RTCMTLVideoView : MTKView |
|
tkchin_webrtc
2017/02/10 23:32:10
I think it is better to subclass UIView here inste
daniela-webrtc
2017/02/13 12:32:07
You are right. I'm already working on a follow up
tkchin_webrtc
2017/02/14 00:23:56
I would prefer that headers that are checked into
|
| + |
| +/** |
| + * Renderer class that can render RTCVideoTrack. |
| + */ |
| +@property(nonatomic, readonly) id<RTCVideoRenderer> renderer; |
| + |
| +/** |
| + * Sets up the renderer. |
| + * |
| + * If the method returns NO it signifies the renderer is unable to perform proper setup and |
| + * it's responsibility of the caller to perform all necessary clean up after this point. |
| + * Unexpected behavior can happen if the cleanup doesn't happen. |
| + */ |
| +- (BOOL)setupRenderer; |
| + |
| +#pragma mark - Unavailable |
|
tkchin_webrtc
2017/02/10 23:32:10
nit: don't need this pragma
|
| +- (instancetype)init NS_UNAVAILABLE; |
| ++ (instancetype) new NS_UNAVAILABLE; |
|
tkchin_webrtc
2017/02/10 23:32:10
nit: remove space
also, ooc why is new explicitly
daniela-webrtc
2017/02/13 12:32:07
Initially it was there because I did the renderer
|
| +@end |
| +NS_ASSUME_NONNULL_END |