Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLRenderer.h

Issue 2651743007: Add metal view, shaders and renderer. (Closed)
Patch Set: Link metal libraries only for arm64cpu Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLRenderer.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLRenderer.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLRenderer.h
new file mode 100644
index 0000000000000000000000000000000000000000..f47a5d14ea363cd7488b779232e2c455bfd857d6
--- /dev/null
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLRenderer.h
@@ -0,0 +1,37 @@
+/*
+ * Copyright 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#import <Foundation/Foundation.h>
+#import "WebRTC/RTCVideoRenderer.h"
+
+@class MTKView;
+
+NS_ASSUME_NONNULL_BEGIN
+RTC_EXPORT
+/**
+ * Render class that uses Metal to render RTCVideoFrame in an instance of MTKView.
+ */
+@protocol RTCMTLRenderer<RTCVideoRenderer>
tkchin_webrtc 2017/02/10 23:32:10 RTCMTLRendere <RTC
+
+- (instancetype)initWithView:(__weak __kindof MTKView *)view;
tkchin_webrtc 2017/02/10 23:32:10 Don't put ctors in protocol decls, overly restrict
daniela-webrtc 2017/02/13 12:32:06 I see your point of this being restrictive and mak
tkchin_webrtc 2017/02/14 00:23:56 Sure, but that can be a base abstract class. In th
+
+/**
+ * Sets up the renderer.
+ *
+ * If the method returns NO it signifies the renderer is unable to perform proper setup and
+ * it's responsibility of the caller to perform all necessary clean up after this point.
+ * Unexpected behavior can happen if the cleanup doesn't happen and the renderer continues
+ * accepting RTCVideoRenderer callbacks.
+ */
+- (BOOL)setup;
+
+@end
+
+NS_ASSUME_NONNULL_END

Powered by Google App Engine
This is Rietveld 408576698