Fixed public_deps for libjingle_peerconnection{,_api}

Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around but did not add public dependencies for the fallbacks, which causes gn gen --check a lot of anger.

NOTRY=true # Only build changes and windows bots are cranky atm.
BUG=webrtc:5883
Review-Url: https://codereview.webrtc.org/2651663002
Cr-Commit-Position: refs/heads/master@{#16214}
Committed: https://chromium.googlesource.com/external/webrtc/+/da250064312d4ad6404ac962fc0ef33b6359bb72

[ossu, 2017-01-23 13:19:09]

Description was changed from

==========
Fixed public_deps for libjingle_peerconnection{,_api}

BUG=webrtc:5806
==========

to

==========
Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around
but did not add public dependencies for the fallbacks, which causes gn gen
--check a lot of anger.

BUG=webrtc:5806
==========

[ossu, 2017-01-23 13:19:09]

ossu@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ossu, 2017-01-23 13:19:14]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 13:19:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-23 13:20:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 13:20:16]

Dry run: Try jobs failed on following builders:
  win_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/17902)
  win_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/10178)
  win_clang_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_rel/builds/10086)
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/15446)
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/22405)
  win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/build...)
  win_x64_clang_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_rel/build...)
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL)
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/21909)

[ossu, 2017-01-23 13:23:09]

PTAL at this small change. I've added libjingle_peerconnection targets as
public_deps as well as normal deps. Not sure if just adding as public_deps is
preferred.

[kjellander_webrtc, 2017-01-23 14:00:44]

On 2017/01/23 13:23:09, ossu wrote:
> PTAL at this small change. I've added libjingle_peerconnection targets as
> public_deps as well as normal deps. Not sure if just adding as public_deps is
> preferred.

Please remove it from normal deps to avoid duplicating them.
Do you plan to remove the public_deps once the targets that needs them are
including them explicitly? If so, please add a TODO as well for that work.

[ossu, 2017-01-23 14:07:05]

Removed.

There's a TODO for removing the api:libjingle_peerconnection target already. I
think api:libjingle_peerconnection_api should remain in the public_deps of
pc:libjingle_peerconnection; to me that makes sense.

[kjellander_webrtc, 2017-01-23 14:43:37]

On 2017/01/23 14:07:05, ossu wrote:
> Removed.

lgtm

> There's a TODO for removing the api:libjingle_peerconnection target already. I
> think api:libjingle_peerconnection_api should remain in the public_deps of
> pc:libjingle_peerconnection; to me that makes sense.

Yeah, you're right about that.

[ossu, 2017-01-23 14:46:29]

The CQ bit was checked by ossu@webrtc.org

[commit-bot: I haz the power, 2017-01-23 14:46:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-23 14:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 14:47:29]

Try jobs failed on following builders:
  win_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/17909)
  win_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/10187)
  win_clang_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_rel/builds/10095)
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/15453)
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/22413)
  win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL)
  win_x64_clang_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/5514)
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)

[ossu, 2017-01-23 15:35:04]

Description was changed from

==========
Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around
but did not add public dependencies for the fallbacks, which causes gn gen
--check a lot of anger.

BUG=webrtc:5806
==========

to

==========
Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around
but did not add public dependencies for the fallbacks, which causes gn gen
--check a lot of anger.

NOTRY=true # Only build changes and win-bots are cranky atm.
BUG=webrtc:5806
==========

[ossu, 2017-01-23 15:35:15]

Description was changed from

==========
Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around
but did not add public dependencies for the fallbacks, which causes gn gen
--check a lot of anger.

NOTRY=true # Only build changes and win-bots are cranky atm.
BUG=webrtc:5806
==========

to

==========
Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around
but did not add public dependencies for the fallbacks, which causes gn gen
--check a lot of anger.

NOTRY=true # Only build changes and windows bots are cranky atm.
BUG=webrtc:5806
==========

[ossu, 2017-01-23 15:35:21]

The CQ bit was checked by ossu@webrtc.org

[commit-bot: I haz the power, 2017-01-23 15:35:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-23 15:37:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485185721148020,
"parent_rev": "50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61", "commit_rev":
"da250064312d4ad6404ac962fc0ef33b6359bb72"}

[commit-bot: I haz the power, 2017-01-23 15:37:46]

Description was changed from

==========
Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around
but did not add public dependencies for the fallbacks, which causes gn gen
--check a lot of anger.

NOTRY=true # Only build changes and windows bots are cranky atm.
BUG=webrtc:5806
==========

to

==========
Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around
but did not add public dependencies for the fallbacks, which causes gn gen
--check a lot of anger.

NOTRY=true # Only build changes and windows bots are cranky atm.
BUG=webrtc:5806

Review-Url: https://codereview.webrtc.org/2651663002
Cr-Commit-Position: refs/heads/master@{#16214}
Committed:
https://chromium.googlesource.com/external/webrtc/+/da250064312d4ad6404ac962f...
==========

[commit-bot: I haz the power, 2017-01-23 15:37:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/da250064312d4ad6404ac962f...

[ossu, 2017-01-24 14:24:09]

Description was changed from

==========
Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around
but did not add public dependencies for the fallbacks, which causes gn gen
--check a lot of anger.

NOTRY=true # Only build changes and windows bots are cranky atm.
BUG=webrtc:5806

Review-Url: https://codereview.webrtc.org/2651663002
Cr-Commit-Position: refs/heads/master@{#16214}
Committed:
https://chromium.googlesource.com/external/webrtc/+/da250064312d4ad6404ac962f...
==========

to

==========
Fixed public_deps for libjingle_peerconnection{,_api}

https://codereview.webrtc.org/2514883002/ changed and moved these targets around
but did not add public dependencies for the fallbacks, which causes gn gen
--check a lot of anger.

NOTRY=true # Only build changes and windows bots are cranky atm.
BUG=webrtc:5883

Review-Url: https://codereview.webrtc.org/2651663002
Cr-Commit-Position: refs/heads/master@{#16214}
Committed:
https://chromium.googlesource.com/external/webrtc/+/da250064312d4ad6404ac962f...
==========