Reland of "H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.

Reland of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.

Fixed memory leak in test case.
 
Original issue's description
> Revert of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header. (patchset #3 id:40001 of https://codereview.webrtc.org/2638933002/ )
> 
> Reason for revert:
> Triggers leak on Linux memcheck (non-default trybot):
> 
> Original issue's description:
> > H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.
> > 
> > - Changed method name to clarify that entire Nalus are expected.
> > - Added unit test code.
> > - Adjusted InsetSpsPpsNalus() implementation to above requirement.
> > 
> > BUG=webrtc:5948
> > 
> > Review-Url: https://codereview.webrtc.org/2638933002
> > Cr-Commit-Position: refs/heads/master@{#16221}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/f53d7374cfa59440f777729d3a0b7dd39830d6ec
> 
> TBR=philipel@webrtc.org,sprang@webrtc.org,johan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5948
> Review-Url: https://codereview.webrtc.org/2649113003
> Cr-Commit-Position: refs/heads/master@{#16225}
> Committed: https://chromium.googlesource.com/external/webrtc/+/914d49d0fd43e5c650edd0d1e44667da924202c3
>   

BUG=webrtc:5948
Review-Url: https://codereview.webrtc.org/2651593004
Cr-Commit-Position: refs/heads/master@{#16235}
Committed: https://chromium.googlesource.com/external/webrtc/+/d2b092f38abad228b4c38697e0c56a189044d9c5

[johan, 2017-01-24 08:05:11]

The CQ bit was checked by johan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 08:05:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-24 08:09:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 08:09:48]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12584)

[johan, 2017-01-24 08:49:00]

The CQ bit was checked by johan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 08:49:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-24 08:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 08:53:14]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12589)

[johan, 2017-01-24 09:24:10]

Description was changed from

==========
Revert "Revert of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with
header. (patchset #3 id:40001 of https://codereview.webrtc.org/2638933002/ )"

This reverts commit 914d49d0fd43e5c650edd0d1e44667da924202c3.

BUG=
==========

to

==========
Reland of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.

Fixed memory leak.
 
Original issue's description
> Revert of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with
header. (patchset #3 id:40001 of https://codereview.webrtc.org/2638933002/ )
> 
> Reason for revert:
> Triggers leak on Linux memcheck (non-default trybot):
> 
> Original issue's description:
> > H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.
> > 
> > - Changed method name to clarify that entire Nalus are expected.
> > - Added unit test code.
> > - Adjusted InsetSpsPpsNalus() implementation to above requirement.
> > 
> > BUG=webrtc:5948
> > 
> > Review-Url: https://codereview.webrtc.org/2638933002
> > Cr-Commit-Position: refs/heads/master@{#16221}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f53d7374cfa59440f777729d3...
> 
> TBR=philipel@webrtc.org,sprang@webrtc.org,johan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5948
> Review-Url: https://codereview.webrtc.org/2649113003
> Cr-Commit-Position: refs/heads/master@{#16225}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/914d49d0fd43e5c650edd0d1e...
>   

BUG=webrtc:5948
==========

[johan, 2017-01-24 09:24:10]

johan@webrtc.org changed reviewers:
+ philipel@webrtc.org, sprang@webrtc.org

[johan, 2017-01-24 09:24:40]

Description was changed from

==========
Reland of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.

Fixed memory leak.
 
Original issue's description
> Revert of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with
header. (patchset #3 id:40001 of https://codereview.webrtc.org/2638933002/ )
> 
> Reason for revert:
> Triggers leak on Linux memcheck (non-default trybot):
> 
> Original issue's description:
> > H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.
> > 
> > - Changed method name to clarify that entire Nalus are expected.
> > - Added unit test code.
> > - Adjusted InsetSpsPpsNalus() implementation to above requirement.
> > 
> > BUG=webrtc:5948
> > 
> > Review-Url: https://codereview.webrtc.org/2638933002
> > Cr-Commit-Position: refs/heads/master@{#16221}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f53d7374cfa59440f777729d3...
> 
> TBR=philipel@webrtc.org,sprang@webrtc.org,johan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5948
> Review-Url: https://codereview.webrtc.org/2649113003
> Cr-Commit-Position: refs/heads/master@{#16225}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/914d49d0fd43e5c650edd0d1e...
>   

BUG=webrtc:5948
==========

to

==========
Reland of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.

Fixed memory leak in test case.
 
Original issue's description
> Revert of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with
header. (patchset #3 id:40001 of https://codereview.webrtc.org/2638933002/ )
> 
> Reason for revert:
> Triggers leak on Linux memcheck (non-default trybot):
> 
> Original issue's description:
> > H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.
> > 
> > - Changed method name to clarify that entire Nalus are expected.
> > - Added unit test code.
> > - Adjusted InsetSpsPpsNalus() implementation to above requirement.
> > 
> > BUG=webrtc:5948
> > 
> > Review-Url: https://codereview.webrtc.org/2638933002
> > Cr-Commit-Position: refs/heads/master@{#16221}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f53d7374cfa59440f777729d3...
> 
> TBR=philipel@webrtc.org,sprang@webrtc.org,johan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5948
> Review-Url: https://codereview.webrtc.org/2649113003
> Cr-Commit-Position: refs/heads/master@{#16225}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/914d49d0fd43e5c650edd0d1e...
>   

BUG=webrtc:5948
==========

[sprang_webrtc, 2017-01-24 09:31:48]

lgtm, but please add a comment explaining why the delete is needed there

[johan, 2017-01-24 09:58:48]

The CQ bit was checked by johan@webrtc.org

[johan, 2017-01-24 09:58:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2651593004/#ps30001 (title:
"Comment.")

[commit-bot: I haz the power, 2017-01-24 09:58:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-24 10:38:17]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1485251928951510,
"parent_rev": "15389c034d45eeaa81b4390a4959ddbc18e47540", "commit_rev":
"d2b092f38abad228b4c38697e0c56a189044d9c5"}

[commit-bot: I haz the power, 2017-01-24 10:38:19]

Description was changed from

==========
Reland of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.

Fixed memory leak in test case.
 
Original issue's description
> Revert of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with
header. (patchset #3 id:40001 of https://codereview.webrtc.org/2638933002/ )
> 
> Reason for revert:
> Triggers leak on Linux memcheck (non-default trybot):
> 
> Original issue's description:
> > H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.
> > 
> > - Changed method name to clarify that entire Nalus are expected.
> > - Added unit test code.
> > - Adjusted InsetSpsPpsNalus() implementation to above requirement.
> > 
> > BUG=webrtc:5948
> > 
> > Review-Url: https://codereview.webrtc.org/2638933002
> > Cr-Commit-Position: refs/heads/master@{#16221}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f53d7374cfa59440f777729d3...
> 
> TBR=philipel@webrtc.org,sprang@webrtc.org,johan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5948
> Review-Url: https://codereview.webrtc.org/2649113003
> Cr-Commit-Position: refs/heads/master@{#16225}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/914d49d0fd43e5c650edd0d1e...
>   

BUG=webrtc:5948
==========

to

==========
Reland of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.

Fixed memory leak in test case.
 
Original issue's description
> Revert of H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with
header. (patchset #3 id:40001 of https://codereview.webrtc.org/2638933002/ )
> 
> Reason for revert:
> Triggers leak on Linux memcheck (non-default trybot):
> 
> Original issue's description:
> > H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.
> > 
> > - Changed method name to clarify that entire Nalus are expected.
> > - Added unit test code.
> > - Adjusted InsetSpsPpsNalus() implementation to above requirement.
> > 
> > BUG=webrtc:5948
> > 
> > Review-Url: https://codereview.webrtc.org/2638933002
> > Cr-Commit-Position: refs/heads/master@{#16221}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f53d7374cfa59440f777729d3...
> 
> TBR=philipel@webrtc.org,sprang@webrtc.org,johan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5948
> Review-Url: https://codereview.webrtc.org/2649113003
> Cr-Commit-Position: refs/heads/master@{#16225}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/914d49d0fd43e5c650edd0d1e...
>   

BUG=webrtc:5948

Review-Url: https://codereview.webrtc.org/2651593004
Cr-Commit-Position: refs/heads/master@{#16235}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d2b092f38abad228b4c38697e...
==========

[commit-bot: I haz the power, 2017-01-24 10:38:20]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/external/webrtc/+/d2b092f38abad228b4c38697e...