Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2651273003: Protect APM in webkit builds. (Closed)

Created:
3 years, 11 months ago by Dr Alex
Modified:
3 years, 10 months ago
Reviewers:
tommi, niklas.enbom
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Protect APM in webkit builds. Update libwertc AudioRtpSender::SetAudioSend with WEBRTC_WEBKIT_BUILD This only introduces the WEBRTC_WEBKIT BUILD, inspired by WEBRTC_CHROMIUM_BUILD macro. It is only defined by Webkit libwebrtc build system. https://trac.webkit.org/changeset/210977 BUG=webrtc:7039 Review-Url: https://codereview.webrtc.org/2651273003 Cr-Commit-Position: refs/heads/master@{#16432} Committed: https://chromium.googlesource.com/external/webrtc/+/b11fb25c1230b2ef1085b9c0aa0642d6494afa88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/rtpsender.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Dr Alex
For your kind review.
3 years, 10 months ago (2017-01-27 09:36:25 UTC) #7
tommi
lgtm
3 years, 10 months ago (2017-01-27 16:27:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2651273003/1
3 years, 10 months ago (2017-02-03 13:37:29 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 14:37:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b11fb25c1230b2ef1085b9c0a...

Powered by Google App Engine
This is Rietveld 408576698