Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2650703002: Delete unused classes DesktopId and ScreencastEventCatcher. (Closed)

Created:
3 years, 11 months ago by nisse-webrtc
Modified:
3 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused classes DesktopId and ScreencastEventCatcher. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2650703002 Cr-Commit-Position: refs/heads/master@{#16228} Committed: https://chromium.googlesource.com/external/webrtc/+/c23b0b26df0ed7d482729dbdc47137ed7a7db788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M webrtc/base/window.h View 1 chunk +0 lines, -48 lines 0 comments Download
M webrtc/media/base/testutils.h View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nisse-webrtc
These classes appear unused. I found them on the list produced by webrtc/tools/class_usage.sh.
3 years, 11 months ago (2017-01-23 12:19:21 UTC) #2
pthatcher1
lgtm
3 years, 11 months ago (2017-01-23 21:32:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2650703002/1
3 years, 11 months ago (2017-01-24 07:26:45 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 08:03:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c23b0b26df0ed7d482729dbdc...

Powered by Google App Engine
This is Rietveld 408576698