Improve bitrate probing for the audio-only case.

Improve bitrate probing for the audio-only case.

This means that smaller probe packets will be allowed at lower bitrates.

BUG=webrtc:7043
Review-Url: https://codereview.webrtc.org/2650393002
Cr-Commit-Position: refs/heads/master@{#16317}
Committed: https://chromium.googlesource.com/external/webrtc/+/f00497c5732b99c42f66023a5b0940c7418d14ed

[stefan-webrtc, 2017-01-25 11:38:18]

.

[stefan-webrtc, 2017-01-25 11:38:37]

stefan@webrtc.org changed reviewers:
+ philipel@webrtc.org, sergeyu@chromium.org

[stefan-webrtc, 2017-01-25 13:11:38]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 13:11:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 13:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 13:35:42]

Dry run: Try jobs failed on following builders:
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/21293)

[philipel, 2017-01-25 13:39:37]

lgtm with one comment.

https://codereview.webrtc.org/2650393002/diff/20001/webrtc/modules/pacing/bit...
File webrtc/modules/pacing/bitrate_prober.cc (right):

https://codereview.webrtc.org/2650393002/diff/20001/webrtc/modules/pacing/bit...
webrtc/modules/pacing/bitrate_prober.cc:67: const size_t kMinProbePacketSize =
200;
Move to anonymous namespace.

[stefan-webrtc, 2017-01-25 14:10:26]

comment addressed.

[stefan-webrtc, 2017-01-26 08:45:38]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 08:45:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-26 08:55:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 08:55:18]

Dry run: Try jobs failed on following builders:
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/21327)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/22107)

[stefan-webrtc, 2017-01-27 09:38:57]

Sergey, I will land this CL, but please review after the fact as I'd really want
your comments.

[stefan-webrtc, 2017-01-27 09:39:02]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2017-01-27 09:39:03]

The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2650393002/#ps40001 (title:
"comment addressed.")

[commit-bot: I haz the power, 2017-01-27 09:39:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-27 10:27:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485509942839450,
"parent_rev": "27378f39ced81acb1c2a61808e5e42fcf65d4b8d", "commit_rev":
"f00497c5732b99c42f66023a5b0940c7418d14ed"}

[commit-bot: I haz the power, 2017-01-27 10:27:40]

Description was changed from

==========
Improve bitrate probing for the audio-only case.

This means that smaller probe packets will be allowed at lower bitrates.

BUG=webrtc:7043
==========

to

==========
Improve bitrate probing for the audio-only case.

This means that smaller probe packets will be allowed at lower bitrates.

BUG=webrtc:7043

Review-Url: https://codereview.webrtc.org/2650393002
Cr-Commit-Position: refs/heads/master@{#16317}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f00497c5732b99c42f66023a5...
==========

[commit-bot: I haz the power, 2017-01-27 10:27:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/f00497c5732b99c42f66023a5...

[Sergey Ulanov, 2017-01-27 19:02:04]

LGTM.

[Sergey Ulanov, 2017-01-27 23:46:43]

BTW RTPSender currently doesn't send padding for audio, see
https://codesearch.chromium.org/chromium/src/third_party/webrtc/modules/rtp_r...
I think it may break probing for audio-only case.
BitrateProber::OnIncomingPacket() only checks that there is a packet for the
first probe. It doesn't verify that we have enough data for the whole probe
cluster.