Pass network config constraint as base64 to avoid mangling bytes

Allow passing network config constraint as base64 encoded string to preserve values of serialized protos. The values are a serialized byte stream packed into a std::string. To be represented as a NSString they must be base64 encoded or bytes outside of the ASCII range will be encoded into multi byte UTF8 sequences by default.

BUG=0
Review-Url: https://codereview.webrtc.org/2650343006
Cr-Commit-Position: refs/heads/master@{#16435}
Committed: https://chromium.googlesource.com/external/webrtc/+/98c437458af3c8270de87dd444b7e0d9856e6ea0

[Chuck, 2017-01-26 18:57:44]

haysc@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2017-02-02 19:04:53]

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm (right):

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:96: return;
nit: log error

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:99: _mandatory[key] =
data;
might break mac build - make sure to run bots ( don't recall if we've moved to
10.8)

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:131: } else {
nit: safer to do an else if NSString then finally an else that asserts and
prints an error

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Hea...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaConstraints.h (right):

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Hea...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaConstraints.h:42: /** Add a new
constraint with raw data/bytes. */
nit: add a comment like:
Some constraint values require arbitrary bytes instead of a UTF-8 string. In
particular, some constraints take the form of a serialized proto, which is
binary. This is a temporary interface until we determine a better solution.

[Chuck, 2017-02-03 15:55:51]

Updated to take a base64 encoded string for that key. PTAL.

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm (right):

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:96: return;
On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> nit: log error

Gone in latest iteration.

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:99: _mandatory[key] =
data;
On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> might break mac build - make sure to run bots ( don't recall if we've moved to
> 10.8)

Gone in latest iteration.

https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:131: } else {
On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> nit: safer to do an else if NSString then finally an else that asserts and
> prints an error

Gone in latest iteration.

[tkchin_webrtc, 2017-02-03 20:02:49]

On 2017/02/03 15:55:51, Chuck wrote:
> Updated to take a base64 encoded string for that key. PTAL.
> 
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> File webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm (right):
> 
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:96: return;
> On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> > nit: log error
> 
> Gone in latest iteration.
> 
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:99: _mandatory[key] =
> data;
> On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> > might break mac build - make sure to run bots ( don't recall if we've moved
to
> > 10.8)
> 
> Gone in latest iteration.
> 
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:131: } else {
> On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> > nit: safer to do an else if NSString then finally an else that asserts and
> > prints an error
> 
> Gone in latest iteration.

lgtm

[tkchin_webrtc, 2017-02-03 20:03:33]

On 2017/02/03 20:02:49, tkchin_webrtc wrote:
> On 2017/02/03 15:55:51, Chuck wrote:
> > Updated to take a base64 encoded string for that key. PTAL.
> > 
> >
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> > File webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm (right):
> > 
> >
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> > webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:96: return;
> > On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> > > nit: log error
> > 
> > Gone in latest iteration.
> > 
> >
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> > webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:99: _mandatory[key]
=
> > data;
> > On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> > > might break mac build - make sure to run bots ( don't recall if we've
moved
> to
> > > 10.8)
> > 
> > Gone in latest iteration.
> > 
> >
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> > webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:131: } else {
> > On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> > > nit: safer to do an else if NSString then finally an else that asserts and
> > > prints an error
> > 
> > Gone in latest iteration.
> 
> lgtm

nit: update CL title

[Chuck, 2017-02-03 20:07:07]

Description was changed from

==========
Allow passing constraints as NSData to preserve values of serialized protos.

BUG=0
==========

to

==========
Allow passing network config constraint as base64 encoded string to preserve
values of serialized protos. The values are a serialized byte stream packed into
a std::string. To be represented as a NSString they must be base64 encoded or
bytes outside of the ASCII range will be encoded into multi byte UTF8 sequences
by default.

BUG=0
==========

[Chuck, 2017-02-03 20:07:29]

On 2017/02/03 20:03:33, tkchin_webrtc wrote:
> On 2017/02/03 20:02:49, tkchin_webrtc wrote:
> > On 2017/02/03 15:55:51, Chuck wrote:
> > > Updated to take a base64 encoded string for that key. PTAL.
> > > 
> > >
> >
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> > > File webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm (right):
> > > 
> > >
> >
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> > > webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:96: return;
> > > On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> > > > nit: log error
> > > 
> > > Gone in latest iteration.
> > > 
> > >
> >
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> > > webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:99:
_mandatory[key]
> =
> > > data;
> > > On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> > > > might break mac build - make sure to run bots ( don't recall if we've
> moved
> > to
> > > > 10.8)
> > > 
> > > Gone in latest iteration.
> > > 
> > >
> >
>
https://codereview.webrtc.org/2650343006/diff/1/webrtc/sdk/objc/Framework/Cla...
> > > webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm:131: } else {
> > > On 2017/02/02 19:04:53, tkchin_webrtc wrote:
> > > > nit: safer to do an else if NSString then finally an else that asserts
and
> > > > prints an error
> > > 
> > > Gone in latest iteration.
> > 
> > lgtm
> 
> nit: update CL title

Done.

[Chuck, 2017-02-03 20:07:44]

The CQ bit was checked by haysc@webrtc.org

[commit-bot: I haz the power, 2017-02-03 20:07:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-03 21:03:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486152464554640,
"parent_rev": "390e64d7ebe15e0e8b21fc1dc49ae3d9b5c545ef", "commit_rev":
"98c437458af3c8270de87dd444b7e0d9856e6ea0"}

[commit-bot: I haz the power, 2017-02-03 21:03:43]

Description was changed from

==========
Allow passing network config constraint as base64 encoded string to preserve
values of serialized protos. The values are a serialized byte stream packed into
a std::string. To be represented as a NSString they must be base64 encoded or
bytes outside of the ASCII range will be encoded into multi byte UTF8 sequences
by default.

BUG=0
==========

to

==========
Allow passing network config constraint as base64 encoded string to preserve
values of serialized protos. The values are a serialized byte stream packed into
a std::string. To be represented as a NSString they must be base64 encoded or
bytes outside of the ASCII range will be encoded into multi byte UTF8 sequences
by default.

BUG=0

Review-Url: https://codereview.webrtc.org/2650343006
Cr-Commit-Position: refs/heads/master@{#16435}
Committed:
https://chromium.googlesource.com/external/webrtc/+/98c437458af3c8270de87dd44...
==========

[commit-bot: I haz the power, 2017-02-03 21:03:44]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/98c437458af3c8270de87dd44...