Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2649353002: Add linux_memcheck as default trybot. (Closed)

Created:
3 years, 11 months ago by kjellander_webrtc
Modified:
3 years, 11 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add linux_memcheck as default trybot. After moving to Swarming, this bot executes in ~20 minutes instead of hours, making it a good candidate for pre-submit checks. It would have caught the leak that led to the revert in https://codereview.webrtc.org/2649113003/ if it would have run. BUG=chromium:497757 TBR=ehmaldonado@webrtc.org Review-Url: https://codereview.webrtc.org/2649353002 . Cr-Commit-Position: refs/heads/master@{#16226} Committed: https://chromium.googlesource.com/external/webrtc/+/2b7552663e8f8923118c92ae07c3563a3b8e1aa6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M infra/config/cq.cfg View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
kjellander_webrtc
Committed patchset #1 (id:1) manually as 2b7552663e8f8923118c92ae07c3563a3b8e1aa6 (presubmit successful).
3 years, 11 months ago (2017-01-24 04:22:46 UTC) #2
ehmaldonado_webrtc
3 years, 11 months ago (2017-01-24 06:37:56 UTC) #3
Message was sent while issue was closed.
On 2017/01/24 04:22:46, kjellander_webrtc wrote:
> Committed patchset #1 (id:1) manually as
> 2b7552663e8f8923118c92ae07c3563a3b8e1aa6 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698