New script to count usage of C++ classes.

New script to count usage of C++ classes.

This script is similar to header_usage.sh, but it counts usage (number
of files) of each class defined in some header file.

E.g., the following classes appear unused,

  AsyncHttpsProxyServerSocket
  CompositeMediaEngineWithFakeVoiceEngine
  DesktopId
  RtpDataCallback
  ScopedMessageData
  ScreencastEventCatcher

NOTRY=true
BUG=None

Review-Url: https://codereview.webrtc.org/2649103002
Cr-Commit-Position: refs/heads/master@{#16204}
Committed: https://chromium.googlesource.com/external/webrtc/+/de8ca92755ecbb9722ba9bbb42a05a9f2d4dd20b

[nisse-webrtc, 2017-01-23 09:44:03]

nisse@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[nisse-webrtc, 2017-01-23 09:44:04]

PTAL. This is a bit crude with lots of false positives, but I think it's still
useful.

[kjellander_webrtc, 2017-01-23 10:23:36]

lgtm with nits fixed

https://codereview.webrtc.org/2649103002/diff/1/webrtc/tools/class_usage.sh
File webrtc/tools/class_usage.sh (right):

https://codereview.webrtc.org/2649103002/diff/1/webrtc/tools/class_usage.sh#n...
webrtc/tools/class_usage.sh:3: # Copyright (c) 2016 The WebRTC project authors.
All Rights Reserved.
2017 :)

https://codereview.webrtc.org/2649103002/diff/1/webrtc/tools/class_usage.sh#n...
webrtc/tools/class_usage.sh:20: count="$(git grep -l -w -F "${class}" \
avoid wrapping here?

[nisse-webrtc, 2017-01-23 10:38:19]

Description was changed from

==========
New script to count usage of C++ classes.

This script is similar to header_usage.sh, but it counts usage (number
of files) of each class defined in some header file.

E.g., the following classes appear unused,

  AsyncHttpsProxyServerSocket
  CompositeMediaEngineWithFakeVoiceEngine
  DesktopId
  RtpDataCallback
  ScopedMessageData
  ScreencastEventCatcher

BUG=None
==========

to

==========
New script to count usage of C++ classes.

This script is similar to header_usage.sh, but it counts usage (number
of files) of each class defined in some header file.

E.g., the following classes appear unused,

  AsyncHttpsProxyServerSocket
  CompositeMediaEngineWithFakeVoiceEngine
  DesktopId
  RtpDataCallback
  ScopedMessageData
  ScreencastEventCatcher

NOTRY=true
BUG=None
==========

[nisse-webrtc, 2017-01-23 10:38:39]

Thanks.

https://codereview.webrtc.org/2649103002/diff/1/webrtc/tools/class_usage.sh
File webrtc/tools/class_usage.sh (right):

https://codereview.webrtc.org/2649103002/diff/1/webrtc/tools/class_usage.sh#n...
webrtc/tools/class_usage.sh:3: # Copyright (c) 2016 The WebRTC project authors.
All Rights Reserved.
On 2017/01/23 10:23:36, kjellander_webrtc wrote:
> 2017 :)

Done.

https://codereview.webrtc.org/2649103002/diff/1/webrtc/tools/class_usage.sh#n...
webrtc/tools/class_usage.sh:20: count="$(git grep -l -w -F "${class}" \
On 2017/01/23 10:23:36, kjellander_webrtc wrote:
> avoid wrapping here?

Done.

[nisse-webrtc, 2017-01-23 10:38:44]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2017-01-23 10:38:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2649103002/#ps20001 (title:
"Address nits.")

[commit-bot: I haz the power, 2017-01-23 10:38:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-23 10:41:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485167924429660,
"parent_rev": "b55bd979725366ce12d84b08e921dc23618a0f74", "commit_rev":
"de8ca92755ecbb9722ba9bbb42a05a9f2d4dd20b"}

[commit-bot: I haz the power, 2017-01-23 10:41:11]

Description was changed from

==========
New script to count usage of C++ classes.

This script is similar to header_usage.sh, but it counts usage (number
of files) of each class defined in some header file.

E.g., the following classes appear unused,

  AsyncHttpsProxyServerSocket
  CompositeMediaEngineWithFakeVoiceEngine
  DesktopId
  RtpDataCallback
  ScopedMessageData
  ScreencastEventCatcher

NOTRY=true
BUG=None
==========

to

==========
New script to count usage of C++ classes.

This script is similar to header_usage.sh, but it counts usage (number
of files) of each class defined in some header file.

E.g., the following classes appear unused,

  AsyncHttpsProxyServerSocket
  CompositeMediaEngineWithFakeVoiceEngine
  DesktopId
  RtpDataCallback
  ScopedMessageData
  ScreencastEventCatcher

NOTRY=true
BUG=None

Review-Url: https://codereview.webrtc.org/2649103002
Cr-Commit-Position: refs/heads/master@{#16204}
Committed:
https://chromium.googlesource.com/external/webrtc/+/de8ca92755ecbb9722ba9bbb4...
==========

[commit-bot: I haz the power, 2017-01-23 10:41:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/de8ca92755ecbb9722ba9bbb4...