Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2648483003: Stop camera onStop instead of onPause. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Stop camera onStop instead of onPause. In multi-window mode the non-active activity receives onPause. We shouldn't stop the camera in this case. BUG=webrtc:7018 Review-Url: https://codereview.webrtc.org/2648483003 Cr-Commit-Position: refs/heads/master@{#16186} Committed: https://chromium.googlesource.com/external/webrtc/+/c854ac3755932ea79ac8791ee2fa21e64e6c7826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sakal
PTAL
3 years, 11 months ago (2017-01-19 14:31:32 UTC) #6
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-20 09:32:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2648483003/40001
3 years, 11 months ago (2017-01-20 09:42:24 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 12:09:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/c854ac3755932ea79ac8791ee...

Powered by Google App Engine
This is Rietveld 408576698