Moving gn_isolate_map.pyl to tools-webrtc/mb

Moving gn_isolate_map.pyl to tools-webrtc/mb

BUG=webrtc:7030
R=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2648353004 .
Cr-Commit-Position: refs/heads/master@{#16262}
Committed: https://chromium.googlesource.com/external/webrtc/+/b63a8ac5da2a45a7d0ccfec70c96eb4e949bd2fe

[mbonadei, 2017-01-24 16:02:56]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-01-25 06:47:05]

On 2017/01/24 16:02:57, mbonadei wrote:

Our bots are passing the path to this file to mb.py. Can you change mb.py so the
default is the new location? 
Then we'll just have to update the buildbot recipe in
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/ap...
to not pass the flag anymore. Then we can land this.

[kjellander_webrtc, 2017-01-25 07:51:08]

On 2017/01/25 06:47:05, kjellander_webrtc wrote:
> On 2017/01/24 16:02:57, mbonadei wrote:
> 
> Our bots are passing the path to this file to mb.py. Can you change mb.py so
the
> default is the new location? 
> Then we'll just have to update the buildbot recipe in
>
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/ap...
> to not pass the flag anymore. Then we can land this.

Actually, let's move it into tools-webrtc/mb/ instead. I wrote the wrong dir in
bug 7030.
I also don't understand how the buildbots can go green with the patch, since
they pass paths like
--isolate-map-file=/b/c/b/android_clang_dbg/src/webrtc/build/gn_isolate_map.pyl
to mb.py without failure (even if this patch deletes the file).
I say we change the default in
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/mb/mb...
(as part of this CL) to be the new location
(tools-webrtc/mb/gn_isolate_map.pyl).
Then I can write the buildbot CL to no longer pass the flag and we'll
synchronize landing both CLs.

[kjellander_webrtc, 2017-01-25 08:00:09]

On 2017/01/25 07:51:08, kjellander_webrtc wrote:
> On 2017/01/25 06:47:05, kjellander_webrtc wrote:
> > On 2017/01/24 16:02:57, mbonadei wrote:
> > 
> > Our bots are passing the path to this file to mb.py. Can you change mb.py so
> the
> > default is the new location? 
> > Then we'll just have to update the buildbot recipe in
> >
>
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/ap...
> > to not pass the flag anymore. Then we can land this.
> 
> Actually, let's move it into tools-webrtc/mb/ instead. I wrote the wrong dir
in
> bug 7030.
> I also don't understand how the buildbots can go green with the patch, since
> they pass paths like
>
--isolate-map-file=/b/c/b/android_clang_dbg/src/webrtc/build/gn_isolate_map.pyl
> to mb.py without failure (even if this patch deletes the file).
> I say we change the default in
>
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/mb/mb...
> (as part of this CL) to be the new location
> (tools-webrtc/mb/gn_isolate_map.pyl).
> Then I can write the buildbot CL to no longer pass the flag and we'll
> synchronize landing both CLs.

Buildbot change: https://chromium-review.googlesource.com/c/432236/

[mbonadei, 2017-01-25 08:04:02]

On 2017/01/25 08:00:09, kjellander_webrtc wrote:
> On 2017/01/25 07:51:08, kjellander_webrtc wrote:
> > On 2017/01/25 06:47:05, kjellander_webrtc wrote:
> > > On 2017/01/24 16:02:57, mbonadei wrote:
> > > 
> > > Our bots are passing the path to this file to mb.py. Can you change mb.py
so
> > the
> > > default is the new location? 
> > > Then we'll just have to update the buildbot recipe in
> > >
> >
>
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/ap...
> > > to not pass the flag anymore. Then we can land this.
> > 
> > Actually, let's move it into tools-webrtc/mb/ instead. I wrote the wrong dir
> in
> > bug 7030.
> > I also don't understand how the buildbots can go green with the patch, since
> > they pass paths like
> >
>
--isolate-map-file=/b/c/b/android_clang_dbg/src/webrtc/build/gn_isolate_map.pyl
> > to mb.py without failure (even if this patch deletes the file).
> > I say we change the default in
> >
>
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/mb/mb...
> > (as part of this CL) to be the new location
> > (tools-webrtc/mb/gn_isolate_map.pyl).
> > Then I can write the buildbot CL to no longer pass the flag and we'll
> > synchronize landing both CLs.
> 
> Buildbot change: https://chromium-review.googlesource.com/c/432236/

PTAL.

[kjellander_webrtc, 2017-01-25 08:16:43]

lgtm

[mbonadei, 2017-01-25 08:17:16]

Description was changed from

==========
Moving gn_isolate_map.pyl to tools-webrtc/gn

BUG=webrtc:7030
==========

to

==========
Moving gn_isolate_map.pyl to tools-webrtc/mb

BUG=webrtc:7030
==========

[mbonadei, 2017-01-25 08:17:26]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-01-25 08:17:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 08:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 08:21:08]

Try jobs failed on following builders:
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/17040)

[mbonadei, 2017-01-25 08:36:55]

Description was changed from

==========
Moving gn_isolate_map.pyl to tools-webrtc/mb

BUG=webrtc:7030
==========

to

==========
Moving gn_isolate_map.pyl to tools-webrtc/mb

BUG=webrtc:7030
R=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2648353004 .
Cr-Commit-Position: refs/heads/master@{#16262}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b63a8ac5da2a45a7d0ccfec70...
==========

[mbonadei, 2017-01-25 08:36:56]

Committed patchset #2 (id:20001) manually as
b63a8ac5da2a45a7d0ccfec70c96eb4e949bd2fe (presubmit successful).