Adding ability for BaseChannel to use PacketTransportInterface.

Adding ability for BaseChannel to use PacketTransportInterface.

... As opposed to DtlsTransportInternal.

The code is suboptimal right now, storing two pointers to the different
interfaces. This will all be cleaned up when we have an "RtpTransport"
abstraction that BaseChannel can use.

This CL also cleans up the "fake transport" classes a bit, and gives
them their own header files.

BUG=None

Review-Url: https://codereview.webrtc.org/2648233003
Cr-Commit-Position: refs/heads/master@{#16258}
Committed: https://chromium.googlesource.com/external/webrtc/+/f534659ee6896b068e562bb873e0dbae5080352e

[Taylor Brandstetter, 2017-01-24 01:55:11]

Description was changed from

==========
Adding ability for BaseChannel to use PacketTransportInterface.

As opposed to DtlsTransportInternal. The code is suboptimal right now,
storing two pointers to the different interfaces. This will all be
cleaned up when we have an "RtpTransport" abstraction that BaseChannel
can use.

This CL also cleans up the "fake transport" classes a bit, and gives
them their own header files.

BUG=None
==========

to

==========
Adding ability for BaseChannel to use PacketTransportInterface.

... As opposed to DtlsTransportInternal.

The code is suboptimal right now, storing two pointers to the different
interfaces. This will all be cleaned up when we have an "RtpTransport"
abstraction that BaseChannel can use.

This CL also cleans up the "fake transport" classes a bit, and gives
them their own header files.

BUG=None
==========

[Taylor Brandstetter, 2017-01-24 02:00:04]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-01-24 02:00:06]

This ended up being a little more work than I expected... I think we should have
gone with "Option #1" (or 2). But it's done now, so...

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/fakecandidate...
File webrtc/p2p/base/fakecandidatepair.h (right):

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/fakecandidate...
webrtc/p2p/base/fakecandidatepair.h:54: #endif  //
WEBRTC_P2P_BASE_FAKECANDIDATEPAIR_H_
Just moved from faketransportcontroller.h.

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/fakedtlstrans...
File webrtc/p2p/base/fakedtlstransport.h (right):

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/fakedtlstrans...
webrtc/p2p/base/fakedtlstransport.h:270: #endif  //
WEBRTC_P2P_BASE_FAKEDTLSTRANSPORT_H_
Moved from faketransportcontroller.h, removed ICE passthrough methods, put
methods in more consistent order.

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/fakeicetransp...
File webrtc/p2p/base/fakeicetransport.h (right):

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/fakeicetransp...
webrtc/p2p/base/fakeicetransport.h:236: #endif  //
WEBRTC_P2P_BASE_FAKEICETRANSPORT_H_
Moved from faketransportcontroller.h, switched to using AsyncInvoker, put
methods in more consistent order.

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/transportcont...
File webrtc/p2p/base/transportcontroller_unittest.cc (right):

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/transportcont...
webrtc/p2p/base/transportcontroller_unittest.cc:849: }  // namespace cricket {
Just renaming/trivial stuff here.

[pthatcher1, 2017-01-25 00:02:19]

lgtm, with nits

I think this thing turned out great.  Sorry it was so much work.

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/transportcont...
File webrtc/p2p/base/transportcontroller_unittest.cc (right):

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/transportcont...
webrtc/p2p/base/transportcontroller_unittest.cc:39: // TODO(deadbeef): Pass a
"TransportTransportFactory" or something similar into
Do you mean TransportControllerFactory?

https://codereview.webrtc.org/2648233003/diff/1/webrtc/pc/channel.h
File webrtc/pc/channel.h (right):

https://codereview.webrtc.org/2648233003/diff/1/webrtc/pc/channel.h#newcode117
webrtc/pc/channel.h:117: // "DtlsTransportInternal", or vide-versa.
vice-versa

[Taylor Brandstetter, 2017-01-25 00:31:43]

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/transportcont...
File webrtc/p2p/base/transportcontroller_unittest.cc (right):

https://codereview.webrtc.org/2648233003/diff/1/webrtc/p2p/base/transportcont...
webrtc/p2p/base/transportcontroller_unittest.cc:39: // TODO(deadbeef): Pass a
"TransportTransportFactory" or something similar into
On 2017/01/25 00:02:19, pthatcher1 wrote:
> Do you mean TransportControllerFactory?

Oops, that was from find/replacing "channel" with "transport".

https://codereview.webrtc.org/2648233003/diff/1/webrtc/pc/channel.h
File webrtc/pc/channel.h (right):

https://codereview.webrtc.org/2648233003/diff/1/webrtc/pc/channel.h#newcode117
webrtc/pc/channel.h:117: // "DtlsTransportInternal", or vide-versa.
On 2017/01/25 00:02:19, pthatcher1 wrote:
> vice-versa

Done.

[Taylor Brandstetter, 2017-01-25 00:40:25]

The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 00:40:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 00:44:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:44:26]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/16792)

[Taylor Brandstetter, 2017-01-25 01:17:25]

The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 01:17:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 01:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 01:25:09]

Dry run: Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/22050)

[Taylor Brandstetter, 2017-01-25 02:01:59]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-25 02:01:59]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2648233003/#ps60001 (title:
"Fixing typo I somehow introduced in the test.")

[commit-bot: I haz the power, 2017-01-25 02:02:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 02:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 02:28:23]

Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/19107)

[Taylor Brandstetter, 2017-01-25 02:34:08]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-25 02:34:08]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2648233003/#ps80001 (title:
"Fixing TSAN race in test.")

[commit-bot: I haz the power, 2017-01-25 02:34:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 03:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 03:01:57]

Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/19108)

[Taylor Brandstetter, 2017-01-25 04:57:04]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-25 04:57:04]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2648233003/#ps100001 (title:
"Fix TSAN warning in test by starting thread after setting fake clock")

[commit-bot: I haz the power, 2017-01-25 04:57:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 05:51:22]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485320224304320,
"parent_rev": "6b75f4d0e77e791f73302746ff322fa1a250ebaa", "commit_rev":
"f534659ee6896b068e562bb873e0dbae5080352e"}

[commit-bot: I haz the power, 2017-01-25 05:51:26]

Description was changed from

==========
Adding ability for BaseChannel to use PacketTransportInterface.

... As opposed to DtlsTransportInternal.

The code is suboptimal right now, storing two pointers to the different
interfaces. This will all be cleaned up when we have an "RtpTransport"
abstraction that BaseChannel can use.

This CL also cleans up the "fake transport" classes a bit, and gives
them their own header files.

BUG=None
==========

to

==========
Adding ability for BaseChannel to use PacketTransportInterface.

... As opposed to DtlsTransportInternal.

The code is suboptimal right now, storing two pointers to the different
interfaces. This will all be cleaned up when we have an "RtpTransport"
abstraction that BaseChannel can use.

This CL also cleans up the "fake transport" classes a bit, and gives
them their own header files.

BUG=None

Review-Url: https://codereview.webrtc.org/2648233003
Cr-Commit-Position: refs/heads/master@{#16258}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f534659ee6896b068e562bb87...
==========

[commit-bot: I haz the power, 2017-01-25 05:51:29]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/f534659ee6896b068e562bb87...