Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 2648003003: Revert of Removing #defines previously used for building without BoringSSL/OpenSSL. (Closed)

Created:
3 years, 11 months ago by Taylor Brandstetter
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, terelius
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Removing #defines previously used for building without BoringSSL/OpenSSL. (patchset #2 id:20001 of https://codereview.webrtc.org/2640513002/ ) Reason for revert: Broke chromium build, due to a config being removed. Will add it back and remove the dependency in a chromium CL. Original issue's description: > Removing #defines previously used for building without BoringSSL/OpenSSL. > > These defines don't work any more, so they only cause confusion: > > FEATURE_ENABLE_SSL > HAVE_OPENSSL_SSL_H > SSL_USE_OPENSSL > > BUG=webrtc:7025 > > Review-Url: https://codereview.webrtc.org/2640513002 > Cr-Commit-Position: refs/heads/master@{#16196} > Committed: https://chromium.googlesource.com/external/webrtc/+/eaa826c2ee0668cfb4a0dfb66f8d388b65da20f5 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7025 Review-Url: https://codereview.webrtc.org/2648003003 Cr-Commit-Position: refs/heads/master@{#16197} Committed: https://chromium.googlesource.com/external/webrtc/+/f33491ebaf3adb2e7afc57ed5735536d17bf0f3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -15 lines) Patch
M webrtc/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 11 chunks +19 lines, -3 lines 0 comments Download
M webrtc/api/peerconnectionendtoend_unittest.cc View 7 chunks +18 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 24 chunks +33 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 3 chunks +22 lines, -0 lines 0 comments Download
M webrtc/base/helpers.cc View 3 chunks +85 lines, -0 lines 0 comments Download
M webrtc/base/messagedigest.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M webrtc/base/openssladapter.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/base/openssldigest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/base/opensslidentity.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/base/opensslstreamadapter.h View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 10 chunks +44 lines, -4 lines 0 comments Download
M webrtc/base/ssladapter.cc View 3 chunks +30 lines, -1 line 0 comments Download
M webrtc/base/ssladapter_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A webrtc/base/sslconfig.h View 1 chunk +30 lines, -0 lines 0 comments Download
M webrtc/base/sslidentity.cc View 3 chunks +15 lines, -1 line 0 comments Download
M webrtc/base/sslstreamadapter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 4 chunks +20 lines, -0 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 22 chunks +32 lines, -0 lines 0 comments Download
M webrtc/p2p/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 24 chunks +24 lines, -0 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 5 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Taylor Brandstetter
Created Revert of Removing #defines previously used for building without BoringSSL/OpenSSL.
3 years, 11 months ago (2017-01-21 01:01:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2648003003/1
3 years, 11 months ago (2017-01-21 01:01:37 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 01:01:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f33491ebaf3adb2e7afc57ed5...

Powered by Google App Engine
This is Rietveld 408576698