Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: webrtc/p2p/base/transportdescriptionfactory.h

Issue 2647593003: Accept SDP with TRANSPORT attributes missing from bundled m= sections. (Closed)
Patch Set: Fixing tests due to bool's meaning being reversed in patchset 4 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/p2p/base/transportdescriptionfactory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/transportdescriptionfactory.h
diff --git a/webrtc/p2p/base/transportdescriptionfactory.h b/webrtc/p2p/base/transportdescriptionfactory.h
index 2dde5b12584b729f6a59963dedd76a82058fc942..ac04f048c610f7051710bb566f0ab263a1513ba7 100644
--- a/webrtc/p2p/base/transportdescriptionfactory.h
+++ b/webrtc/p2p/base/transportdescriptionfactory.h
@@ -53,9 +53,16 @@ class TransportDescriptionFactory {
TransportDescription* CreateOffer(const TransportOptions& options,
const TransportDescription* current_description) const;
// Create a transport description that is a response to an offer.
+ //
+ // If |require_transport_attributes| is true, then TRANSPORT category
+ // attributes are expected to be present in |offer|, as defined by
+ // sdp-mux-attributes, and null will be returned otherwise. It's expected
+ // that this will be set to false for an m= section that's in a BUNDLE group
+ // but isn't the first m= section in the group.
TransportDescription* CreateAnswer(
const TransportDescription* offer,
const TransportOptions& options,
+ bool require_transport_attributes,
const TransportDescription* current_description) const;
private:
« no previous file with comments | « no previous file | webrtc/p2p/base/transportdescriptionfactory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698