Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: webrtc/p2p/base/transportdescriptionfactory.h

Issue 2647593003: Accept SDP with TRANSPORT attributes missing from bundled m= sections. (Closed)
Patch Set: Fixing tests due to bool's meaning being reversed in patchset 4 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/p2p/base/transportdescriptionfactory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2012 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 // Specifies the certificate to use (only used when secure != SEC_DISABLED). 46 // Specifies the certificate to use (only used when secure != SEC_DISABLED).
47 void set_certificate( 47 void set_certificate(
48 const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) { 48 const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) {
49 certificate_ = certificate; 49 certificate_ = certificate;
50 } 50 }
51 51
52 // Creates a transport description suitable for use in an offer. 52 // Creates a transport description suitable for use in an offer.
53 TransportDescription* CreateOffer(const TransportOptions& options, 53 TransportDescription* CreateOffer(const TransportOptions& options,
54 const TransportDescription* current_description) const; 54 const TransportDescription* current_description) const;
55 // Create a transport description that is a response to an offer. 55 // Create a transport description that is a response to an offer.
56 //
57 // If |require_transport_attributes| is true, then TRANSPORT category
58 // attributes are expected to be present in |offer|, as defined by
59 // sdp-mux-attributes, and null will be returned otherwise. It's expected
60 // that this will be set to false for an m= section that's in a BUNDLE group
61 // but isn't the first m= section in the group.
56 TransportDescription* CreateAnswer( 62 TransportDescription* CreateAnswer(
57 const TransportDescription* offer, 63 const TransportDescription* offer,
58 const TransportOptions& options, 64 const TransportOptions& options,
65 bool require_transport_attributes,
59 const TransportDescription* current_description) const; 66 const TransportDescription* current_description) const;
60 67
61 private: 68 private:
62 bool SetSecurityInfo(TransportDescription* description, 69 bool SetSecurityInfo(TransportDescription* description,
63 ConnectionRole role) const; 70 ConnectionRole role) const;
64 71
65 SecurePolicy secure_; 72 SecurePolicy secure_;
66 rtc::scoped_refptr<rtc::RTCCertificate> certificate_; 73 rtc::scoped_refptr<rtc::RTCCertificate> certificate_;
67 }; 74 };
68 75
69 } // namespace cricket 76 } // namespace cricket
70 77
71 #endif // WEBRTC_P2P_BASE_TRANSPORTDESCRIPTIONFACTORY_H_ 78 #endif // WEBRTC_P2P_BASE_TRANSPORTDESCRIPTIONFACTORY_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/p2p/base/transportdescriptionfactory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698