Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Issue 2647003002: GN: Make audio_processing_unittests compile with rtc_enable_protobuf=false (Closed)

Created:
3 years, 11 months ago by ehmaldonado_webrtc
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Make audio_processing_unittests compile with rtc_enable_protobuf=false BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2647003002 Cr-Commit-Position: refs/heads/master@{#16209} Committed: https://chromium.googlesource.com/external/webrtc/+/f49ff260d1843975f134416d694bd77d829e4201

Patch Set 1 #

Patch Set 2 : Test with rtc_set_protobuf=false. #

Patch Set 3 : Fix Android. #

Patch Set 4 : Revert mb_config.pyl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M webrtc/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 4 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ehmaldonado_webrtc
I'm not sure running trybots will be useful, since all of them have rtc_enable_protobuf=true.
3 years, 11 months ago (2017-01-20 13:49:38 UTC) #3
kjellander_webrtc
lgtm
3 years, 11 months ago (2017-01-20 14:23:33 UTC) #4
ehmaldonado_webrtc
On 2017/01/20 14:23:33, kjellander_webrtc wrote: > lgtm PTAL (I'll revert the mb_config.pyl changes)
3 years, 11 months ago (2017-01-23 10:34:48 UTC) #5
kjellander_webrtc
On 2017/01/23 10:34:48, ehmaldonado_webrtc wrote: > On 2017/01/20 14:23:33, kjellander_webrtc wrote: > > lgtm > ...
3 years, 11 months ago (2017-01-23 12:04:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2647003002/80001
3 years, 11 months ago (2017-01-23 12:23:47 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 12:26:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/f49ff260d1843975f134416d6...

Powered by Google App Engine
This is Rietveld 408576698