Remove dead code for GtkVideoRenderer.

Remove dead code for GtkVideoRenderer.

Pulls in unnecessary GTK dependencies that breaks the chromium GTK3
build. This removes the last of webrtc/media/devices.

BUG=chromium:668446
Review-Url: https://codereview.webrtc.org/2646793008
Cr-Commit-Position: refs/heads/master@{#16198}
Committed: https://chromium.googlesource.com/external/webrtc/+/2197e9186087012fb677a5865a42835297cdea19

[pbos-webrtc, 2017-01-20 22:39:18]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 22:39:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Tom (Use chromium acct), 2017-01-20 23:13:13]

thomasanderson@google.com changed reviewers:
+ thomasanderson@google.com

[Tom (Use chromium acct), 2017-01-20 23:13:13]

https://codereview.webrtc.org/2646793008/diff/1/webrtc/media/BUILD.gn
File webrtc/media/BUILD.gn (right):

https://codereview.webrtc.org/2646793008/diff/1/webrtc/media/BUILD.gn#newcode35
webrtc/media/BUILD.gn:35: if (is_linux && rtc_use_gtk) {
Please also remove this to fix the bug

[pbos-webrtc, 2017-01-20 23:15:06]

remove pkg_config entries for rtc_use_gtk in webrtc/media/BUILD.gn

[pbos-webrtc, 2017-01-20 23:15:52]

Description was changed from

==========
Remove dead code for GtkVideoRenderer.

Pulls in unnecessary gtk requirements and breaks chrome GTK3 build.

BUG=chromium:668446
R=kjellander@webrtc.org
==========

to

==========
Remove dead code for GtkVideoRenderer.

Pulls in unnecessary GTK dependencies and breaks chrome GTK3 build.

BUG=chromium:668446
R=kjellander@webrtc.org
==========

[pbos-webrtc, 2017-01-20 23:16:02]

https://codereview.webrtc.org/2646793008/diff/1/webrtc/media/BUILD.gn
File webrtc/media/BUILD.gn (right):

https://codereview.webrtc.org/2646793008/diff/1/webrtc/media/BUILD.gn#newcode35
webrtc/media/BUILD.gn:35: if (is_linux && rtc_use_gtk) {
On 2017/01/20 23:13:13, Tom Anderson wrote:
> Please also remove this to fix the bug

Done.

[pbos-webrtc, 2017-01-20 23:16:38]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 23:16:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Tom (Use chromium acct), 2017-01-20 23:37:08]

On 2017/01/20 23:16:02, pbos-webrtc wrote:
> https://codereview.webrtc.org/2646793008/diff/1/webrtc/media/BUILD.gn
> File webrtc/media/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2646793008/diff/1/webrtc/media/BUILD.gn#newcode35
> webrtc/media/BUILD.gn:35: if (is_linux && rtc_use_gtk) {
> On 2017/01/20 23:13:13, Tom Anderson wrote:
> > Please also remove this to fix the bug
> 
> Done.

thanks this lgtm!

[pbos-webrtc, 2017-01-20 23:57:02]

On 2017/01/20 23:37:08, Tom Anderson wrote:
> On 2017/01/20 23:16:02, pbos-webrtc wrote:
> > https://codereview.webrtc.org/2646793008/diff/1/webrtc/media/BUILD.gn
> > File webrtc/media/BUILD.gn (right):
> > 
> >
>
https://codereview.webrtc.org/2646793008/diff/1/webrtc/media/BUILD.gn#newcode35
> > webrtc/media/BUILD.gn:35: if (is_linux && rtc_use_gtk) {
> > On 2017/01/20 23:13:13, Tom Anderson wrote:
> > > Please also remove this to fix the bug
> > 
> > Done.
> 
> thanks this lgtm!

This breaks downstream dependencies. I'll see if I can move it downstream
instead.

[commit-bot: I haz the power, 2017-01-21 00:32:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:32:07]

Dry run: This issue passed the CQ dry run.

[pbos-webrtc, 2017-01-21 01:55:07]

Description was changed from

==========
Remove dead code for GtkVideoRenderer.

Pulls in unnecessary GTK dependencies and breaks chrome GTK3 build.

BUG=chromium:668446
R=kjellander@webrtc.org
==========

to

==========
Remove dead code for GtkVideoRenderer.

Pulls in unnecessary GTK dependencies that breaks the chromium GTK3
build. This removes the last of webrtc/media/devices.

BUG=chromium:668446
==========

[pbos-webrtc, 2017-01-21 02:10:27]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2017-01-21 02:10:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-21 02:13:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484964627719420,
"parent_rev": "f33491ebaf3adb2e7afc57ed5735536d17bf0f3c", "commit_rev":
"2197e9186087012fb677a5865a42835297cdea19"}

[commit-bot: I haz the power, 2017-01-21 02:13:10]

Description was changed from

==========
Remove dead code for GtkVideoRenderer.

Pulls in unnecessary GTK dependencies that breaks the chromium GTK3
build. This removes the last of webrtc/media/devices.

BUG=chromium:668446
==========

to

==========
Remove dead code for GtkVideoRenderer.

Pulls in unnecessary GTK dependencies that breaks the chromium GTK3
build. This removes the last of webrtc/media/devices.

BUG=chromium:668446

Review-Url: https://codereview.webrtc.org/2646793008
Cr-Commit-Position: refs/heads/master@{#16198}
Committed:
https://chromium.googlesource.com/external/webrtc/+/2197e9186087012fb677a5865...
==========

[commit-bot: I haz the power, 2017-01-21 02:13:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/2197e9186087012fb677a5865...