Creating libwebrtc bundle jar

webrtc/examples/BUILD.gn

Index: webrtc/examples/BUILD.gn
diff --git a/webrtc/examples/BUILD.gn b/webrtc/examples/BUILD.gn
index 3764b5c72c1fd55d2a4b832e3c4b288a53cdd64f..eaa3bc91836dbb5a147e56643a2e3950da1dba39 100644
--- a/webrtc/examples/BUILD.gn
+++ b/webrtc/examples/BUILD.gn
@@ -93,6 +93,7 @@ if (is_android) {
       ":AppRTCMobile_resources",
       "//webrtc/base:base_java",
       "//webrtc/examples/androidapp/third_party/autobanh:autobanh_java",
+      "//webrtc/modules/audio_device:audio_device_java",

[sakal, 2017/01/18 13:21:44]

Is this really needed? //webrtc/sdk/android:libjingle_peerconnection_java
already depends on //webrtc/modules/audio_device:audio_device_java.

If you need to add this dependency to projects, this patch will break downstream
dependencies that have to be fixed.

[mbonadei, 2017/01/19 08:30:45]

It seems to be. I tried to comment the dependency but it results in this error:

../../webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:54:
error: package org.webrtc.voiceengine does not exist
import org.webrtc.voiceengine.WebRtcAudioManager;
[...]

It seems that deps are not transitive. Were you expecting them to be transitive?

[sakal, 2017/01/19 09:06:21]

It is a shame. It would be nice to be able to just include a single target to
use WebRTC java code. I guess it is fine though. We are trying to bring all Java
code under sdk/android eventually.

[mbonadei, 2017/01/19 21:20:03]

Yes it is, I think there will be some good reasons for this (such as those that
led us to the dist_jar target instead of adding public_deps to android_library).

       "//webrtc/sdk/android:libjingle_peerconnection_java",
       "//webrtc/sdk/android:libjingle_peerconnection_metrics_default_java",
     ]