Creating libwebrtc bundle jar

webrtc/examples/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../build/webrtc.gni")
 if (is_android) {
@@ skipping 75 matching lines @@
       "androidapp/src/org/appspot/apprtc/WebSocketChannelClient.java",
       "androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java",
       "androidapp/src/org/appspot/apprtc/util/AppRTCUtils.java",
       "androidapp/src/org/appspot/apprtc/util/AsyncHttpURLConnection.java",
     ]
 
     deps = [
       ":AppRTCMobile_resources",
       "//webrtc/base:base_java",
       "//webrtc/examples/androidapp/third_party/autobanh:autobanh_java",
+      "//webrtc/modules/audio_device:audio_device_java",

[sakal, 2017/01/18 13:21:44]

Is this really needed? //webrtc/sdk/android:libjingle_peerconnection_java
already depends on //webrtc/modules/audio_device:audio_device_java.

If you need to add this dependency to projects, this patch will break downstream
dependencies that have to be fixed.

[mbonadei, 2017/01/19 08:30:45]

It seems to be. I tried to comment the dependency but it results in this error:

../../webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:54:
error: package org.webrtc.voiceengine does not exist
import org.webrtc.voiceengine.WebRtcAudioManager;
[...]

It seems that deps are not transitive. Were you expecting them to be transitive?

[sakal, 2017/01/19 09:06:21]

It is a shame. It would be nice to be able to just include a single target to
use WebRTC java code. I guess it is fine though. We are trying to bring all Java
code under sdk/android eventually.

[mbonadei, 2017/01/19 21:20:03]

Yes it is, I think there will be some good reasons for this (such as those that
led us to the dist_jar target instead of adding public_deps to android_library).

       "//webrtc/sdk/android:libjingle_peerconnection_java",
       "//webrtc/sdk/android:libjingle_peerconnection_metrics_default_java",
     ]
   }
 
   android_resources("AppRTCMobile_resources") {
     resource_dirs = [ "androidapp/res" ]
     custom_package = "org.appspot.apprtc"
   }
 
@@ skipping 502 matching lines @@
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
     deps = [
       "../p2p:libstunprober",
       "../p2p:rtc_p2p",
       "../system_wrappers:field_trial_default",
     ]
   }
 }