Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2646093004: Reland of Creating libwebrtc bundle jar (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Creating libwebrtc bundle jar (patchset #1 id:1 of https://codereview.webrtc.org/2640023010/ ) Reason for revert: It seems that we cannot skip the generation of "//webrtc/base/base_java" in chromium without some refactoring because it is included as a dependency in some places. Original issue's description: > Revert of Creating libwebrtc bundle jar (patchset #4 id:60001 of https://codereview.webrtc.org/2646443002/ ) > > Reason for revert: > This breaks some chromium.webrtc.fyi buildbots with the following error: > > ERROR Unresolved dependencies. > //third_party/webrtc/base:base(//build/toolchain/android:android_arm) > needs //third_party/webrtc/base:base_java(//build/toolchain/android:android_arm) > > > Original issue's description: > > Creating libwebrtc bundle jar > > > > Creates a JAR which includes: > > - //webrtc/base:base_java > > - //webrtc/modules/audio_device:audio_device_java > > - //webrtc/sdk/android:libjingle_peerconnection_java > > - //webrtc/sdk/android:libjingle_peerconnection_metrics_default_java > > > > The libwebrtc.jar file will be generated at '<output_dir>/lib.java/webrtc/sdk/android/libwebrtc.jar'. > > > > BUG=webrtc:6356 > > > > Review-Url: https://codereview.webrtc.org/2646443002 > > Cr-Commit-Position: refs/heads/master@{#16189} > > Committed: https://chromium.googlesource.com/external/webrtc/+/a62a82b7e7da5a1bbbf8b5614ef19334cc1603ce > > TBR=kjellander@webrtc.org,sakal@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6356 > > Review-Url: https://codereview.webrtc.org/2640023010 > Cr-Commit-Position: refs/heads/master@{#16190} > Committed: https://chromium.googlesource.com/external/webrtc/+/3c9151b9532b372a35f0b81cc7c6b34d820506e1 TBR=kjellander@webrtc.org,sakal@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6356 Review-Url: https://codereview.webrtc.org/2646093004 Cr-Commit-Position: refs/heads/master@{#16203} Committed: https://chromium.googlesource.com/external/webrtc/+/b55bd979725366ce12d84b08e921dc23618a0f74

Patch Set 1 #

Patch Set 2 : Building base_java even on chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -33 lines) Patch
M webrtc/build/webrtc.gni View 1 1 chunk +0 lines, -29 lines 0 comments Download
M webrtc/examples/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/sdk/android/BUILD.gn View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mbonadei
Created Reland of Creating libwebrtc bundle jar
3 years, 11 months ago (2017-01-20 14:52:20 UTC) #1
kjellander_webrtc
lgtm but ideally we'd get rid of Chromium building the base_java since it's not used. ...
3 years, 11 months ago (2017-01-23 08:29:32 UTC) #2
sakal
still lgtm
3 years, 11 months ago (2017-01-23 09:22:16 UTC) #3
mbonadei
On 2017/01/23 08:29:32, kjellander_webrtc wrote: > lgtm but ideally we'd get rid of Chromium building ...
3 years, 11 months ago (2017-01-23 09:25:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2646093004/150001
3 years, 11 months ago (2017-01-23 09:25:47 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 09:25:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:150001) as
https://chromium.googlesource.com/external/webrtc/+/b55bd979725366ce12d84b08e...

Powered by Google App Engine
This is Rietveld 408576698